PR DAN & SHARI by shari12 · Pull Request #12 · Laboratoria/CDMX009-BurgerQueen

shari12 · 2020-07-28T17:18:31Z

Hola, estamos listas para que revisión de código y feedback....

…floor

AdrianaHY · 2020-07-30T15:41:53Z

+      setMesa(result);
+    };
+    const unsubscribe = showTables2(cb);
+    //return unsubscribe


Eliminen este código.

AdrianaHY · 2020-07-30T15:44:23Z

+    const cb = (result) => {
+        console.log(result)
+      }
+    let imagen= showTables2(cb)


No entiendo muy bien este test, para que es la función cb?

AdrianaHY · 2020-07-30T15:44:36Z

+  fireEvent.click(link);
+  expect(link.closest('a')).toHaveAttribute('href', `/roles/piso/${link.id}`); 
+});
+


Cuiden su formato.

AdrianaHY · 2020-07-30T15:44:51Z

+    text-align: center;
+    margin-bottom: 25px;
+}
+


Procuren utilizar clases para dar estilos

AdrianaHY · 2020-07-30T15:45:14Z

+
+.cols-center{
+    display: flex;
+    justify-content: center;


Cuiden su indentación.

AdrianaHY · 2020-07-30T15:45:58Z

@@ -0,0 +1,21 @@
+import React from 'react'
+
+const Form = (props) => {


Intenteden destructurar sus props:

const From = ({types, text, val}) => {}

AdrianaHY · 2020-07-30T15:46:36Z

+import { Row, Col, Modal } from "react-bootstrap";
+import { showInfoTables } from "../../controllers";
+
+const GetCheck = ({ state }) => {


En algunos documentos si hacen destructure, deben tener consistencia.

AdrianaHY · 2020-07-30T15:46:59Z

+     // } //catch (error) {
+       // return error
+      //}
+    };


Eliminen código innecesario.

AdrianaHY · 2020-07-30T15:47:40Z

+import { Container, Row, Col } from "react-bootstrap";
+import LogOut from "../LogOut/LogOut";
+import { withRouter } from 'react-router-dom'
+import "./kitchen.css";


Acomoden los import en sus archivos como se los indiqué en el comentario anterior.

AdrianaHY · 2020-07-30T15:50:15Z

+
+});
+
+


Cuiden su indentación :)

AdrianaHY · 2020-07-30T15:50:48Z

+font-style: normal;
+font-weight: bold;
+}
+


El nombre de sus clases debe ser más específico: kitchen-buttons

AdrianaHY · 2020-07-30T15:51:42Z

+    )
+}
+
+export default withRouter(LogOut)


Les faltan ; si los utilizan en algún lugar deben usarlos entonces todo el tiempo, recuerden la consistencia.

AdrianaHY · 2020-07-30T15:52:19Z

+  font-weight: bold;
+  font-size: 20px;
+  text-align: center;
+}


El nombre de las clases debe referirse a lo que hace el elemento no a como se ve, btnStyle no es una buen nombre, podría ser algo como logout-button

AdrianaHY · 2020-07-30T15:52:44Z

+  );
+};
+
+export default Login;


El formato de este archivo está muy bien! Así deberían verse los demás.

AdrianaHY · 2020-07-30T15:53:26Z

+
+.lgn{
+    background-color: white;
+}


Intenten configurar un lint para que les ayude con su formato y también el espaciado que dejan a la izquierda para que sus archivos estén uniformes.

AdrianaHY · 2020-07-30T15:57:40Z

+  let conteinerMenu= getByTestId("addItem")
+   expect(conteinerMenu.children.length>0).toBe(true);
+
+  });


Sus tests está. muy bueno! solo eliminen el código innecesario.

AdrianaHY · 2020-07-30T15:58:34Z

+import './ready.css';
+const moment = require('moment')
+
+const Ready = (props) => {


Lo mismo de las props.

AdrianaHY · 2020-07-30T16:00:57Z

+   status:"Preparando",
+   timeFinal:"",
+   timeOut:"",
+   timePrep:1299 }] 


Quizá esto podría sacarse a otro archivo en donde haya pura data mock y así los tests quedarían más limpios

AdrianaHY · 2020-07-30T16:01:26Z

+
+//     // ...
+//   });
+// });


Eliminen el código innecesario

AdrianaHY · 2020-07-30T16:02:06Z

@@ -0,0 +1,9 @@
+body{
+    background-color: #434C78;
+}


Tengan cuidado con los selectors de etiqueta, sean más específicas.

AdrianaHY · 2020-07-30T16:02:49Z

+//  console.log(arrayData)
+//  return arrayData
+//}
+


Eliminen código innecesario

AdrianaHY · 2020-07-30T16:03:15Z

+<path d="M66.0951 16.3287H82.9866V4.55469C82.9866 2.55006 84.5788 0.929688 86.5405 0.929688C88.5023 0.929688 90.0944 2.55006 90.0944 4.55469V16.3287H98.0906V4.55469C98.0906 2.55006 99.6827 0.929688 101.644 0.929688C103.606 0.929688 105.198 2.55006 105.198 4.55469V16.3287H133.292V4.55469C133.292 2.55006 134.884 0.929688 136.845 0.929688C138.807 0.929688 140.399 2.55006 140.399 4.55469V16.3287H148.396V4.55469C148.396 2.55006 149.988 0.929688 151.949 0.929688C153.911 0.929688 155.503 2.55006 155.503 4.55469V16.3287H183.597V4.55469C183.597 2.55006 185.189 0.929688 187.15 0.929688C189.112 0.929688 190.704 2.55006 190.704 4.55469V16.3287H198.7V4.55469C198.7 2.55006 200.293 0.929688 202.254 0.929688C204.216 0.929688 205.808 2.55006 205.808 4.55469V16.3287H233.901V4.55469C233.901 2.55006 235.494 0.929688 237.455 0.929688C239.417 0.929688 241.009 2.55006 241.009 4.55469V16.3287H249.005V4.55469C249.005 2.55006 250.598 0.929688 252.559 0.929688C254.521 0.929688 256.113 2.55006 256.113 4.55469V16.3287H272.113C274.074 16.3287 275.667 17.9491 275.667 19.9537V287.305C275.667 289.309 274.074 290.93 272.113 290.93H66.0951C64.1334 290.93 62.5413 289.309 62.5413 287.305V19.9537C62.5413 17.9491 64.1299 16.3287 66.0951 16.3287ZM69.649 283.68H268.559V23.5787H256.113V35.3563C256.113 37.3609 254.521 38.9813 252.559 38.9813C250.598 38.9813 249.005 37.3609 249.005 35.3563V23.5787H241.009V35.3563C241.009 37.3609 239.417 38.9813 237.455 38.9813C235.494 38.9813 233.901 37.3609 233.901 35.3563V23.5787H205.808V35.3563C205.808 37.3609 204.216 38.9813 202.254 38.9813C200.293 38.9813 198.7 37.3609 198.7 35.3563V23.5787H190.704V35.3563C190.704 37.3609 189.112 38.9813 187.15 38.9813C185.189 38.9813 183.597 37.3609 183.597 35.3563V23.5787H155.503V35.3563C155.503 37.3609 153.911 38.9813 151.949 38.9813C149.988 38.9813 148.396 37.3609 148.396 35.3563V23.5787H140.399V35.3563C140.399 37.3609 138.807 38.9813 136.845 38.9813C134.884 38.9813 133.292 37.3609 133.292 35.3563V23.5787H105.198V35.3563C105.198 37.3609 103.606 38.9813 101.644 38.9813C99.6827 38.9813 98.0906 37.3609 98.0906 35.3563V23.5787H90.0944V35.3563C90.0944 37.3609 88.5023 38.9813 86.5405 38.9813C84.5788 38.9813 82.9866 37.3609 82.9866 35.3563V23.5787H69.649V283.68Z" fill="#FDAD19"/>
+<path d="M101.701 136.662V122.958C97.8624 120.887 95.2128 116.829 95.2128 112.109V104.997C95.2128 81.0996 114.34 61.6619 137.848 61.6619H201.983C225.494 61.6619 244.618 81.0996 244.618 104.997V112.109C244.618 117.224 241.534 121.618 237.161 123.479V136.662C243.738 137.831 248.788 144.086 248.788 151.665V155.296C248.788 161.569 245.334 166.962 240.416 169.3C245.427 175.747 244.575 183.139 244.526 183.529C244.29 185.328 242.78 186.675 240.993 186.675C239.269 186.675 238.008 186.907 236.926 187.279V200.636C238.511 201.382 239.953 202.482 241.171 203.916C243.842 207.072 245.017 211.321 244.39 215.582L243.162 223.95C241.627 234.393 233.607 241.969 224.091 241.969H114.743C105.227 241.969 97.2071 234.393 95.6758 223.95L94.4436 215.582C93.8168 211.321 94.9884 207.072 97.6629 203.916C98.7634 202.616 100.063 201.624 101.466 200.889V187.171C100.473 186.878 99.351 186.679 97.8374 186.679C95.8859 186.679 94.294 185.082 94.2762 183.095C94.2726 182.748 94.2762 176.011 98.7634 169.445C93.6637 167.197 90.0419 161.721 90.0419 155.303V151.673C90.0454 144.078 95.1131 137.82 101.701 136.662ZM230.042 136.332V124.438H108.824V136.332H161.363C169.03 136.332 176.516 139.833 181.901 145.932L188.721 153.663L195.54 145.932C200.925 139.829 208.411 136.332 216.078 136.332H230.042ZM237.496 105C237.496 85.0993 221.563 68.9049 201.983 68.9049H137.848C118.265 68.9049 102.335 85.0993 102.335 105V112.113C102.335 114.915 104.579 117.199 107.339 117.199H232.492C235.248 117.199 237.496 114.915 237.496 112.113V105V105ZM231.474 170.759C231.384 170.705 231.338 170.614 231.256 170.549H107.253C103.917 173.63 102.467 177.249 101.858 179.801C104.871 180.377 106.869 181.546 108.571 182.545C110.612 183.736 112.221 184.681 115.747 184.681C119.269 184.681 120.882 183.736 122.923 182.545C125.284 181.162 128.226 179.443 133.653 179.443C139.077 179.443 142.015 181.166 144.376 182.545C146.413 183.736 148.023 184.681 151.545 184.681C155.067 184.681 156.676 183.736 158.717 182.545C161.078 181.162 164.016 179.443 169.444 179.443C174.871 179.443 177.809 181.166 180.167 182.545C182.204 183.736 183.813 184.681 187.335 184.681C190.854 184.681 192.464 183.736 194.501 182.545C196.862 181.162 199.8 179.443 205.224 179.443C210.647 179.443 213.585 181.166 215.946 182.545C217.983 183.736 219.59 184.681 223.112 184.681C226.634 184.681 228.24 183.736 230.277 182.545C232.047 181.51 234.137 180.283 237.353 179.736C236.958 177.17 235.637 173.42 231.474 170.759ZM121.887 199.659C129.974 199.659 137.877 203.354 143.557 209.79L149.907 216.99L156.256 209.79C161.936 203.354 169.835 199.659 177.926 199.659H229.807V190.809C228.065 191.449 225.925 191.916 223.108 191.916C217.684 191.916 214.746 190.193 212.385 188.814C210.348 187.623 208.742 186.679 205.22 186.679C201.698 186.679 200.092 187.623 198.051 188.814C195.69 190.197 192.756 191.916 187.332 191.916C181.908 191.916 178.966 190.193 176.609 188.814C174.572 187.623 172.962 186.679 169.44 186.679C165.918 186.679 164.308 187.623 162.268 188.814C159.907 190.197 156.969 191.916 151.541 191.916C146.117 191.916 143.176 190.193 140.818 188.814C138.781 187.623 137.171 186.679 133.649 186.679C130.124 186.679 128.514 187.623 126.473 188.814C124.112 190.197 121.171 191.916 115.743 191.916C112.67 191.916 110.412 191.359 108.589 190.631V199.659H121.887ZM101.488 214.514L102.72 222.883C103.728 229.746 108.785 234.726 114.743 234.726H224.095C230.053 234.726 235.11 229.746 236.121 222.883L237.35 214.514C237.663 212.371 237.075 210.178 235.779 208.643C235.013 207.742 234.07 207.144 233.051 206.898H177.934C171.776 206.898 165.961 209.642 161.566 214.626L152.563 224.83C151.887 225.594 150.925 226.032 149.91 226.032C148.895 226.032 147.934 225.594 147.257 224.83L138.254 214.626C133.86 209.642 128.044 206.898 121.887 206.898H105.786C104.768 207.144 103.824 207.745 103.058 208.643C101.762 210.178 101.171 212.375 101.488 214.514ZM97.1679 155.3C97.1679 159.716 100.174 163.31 103.867 163.31H234.971C238.664 163.31 241.669 159.716 241.669 155.3V151.669C241.669 147.253 238.664 143.659 234.971 143.659H233.297C233.144 143.659 233.016 143.59 232.866 143.572H216.078C210.348 143.572 204.939 146.127 200.847 150.768L191.374 161.504C190.697 162.267 189.736 162.705 188.721 162.705C187.706 162.705 186.744 162.267 186.068 161.504L176.595 150.768C172.503 146.127 167.093 143.572 161.363 143.572H105.263C105.092 143.572 104.946 143.496 104.782 143.474C104.483 143.557 104.194 143.662 103.87 143.662C100.174 143.662 97.1715 147.257 97.1715 151.673V155.3H97.1679Z" fill="#FDAD19"/>
+<path d="M4.2243 19.477H14.9152V4.54937C14.9152 2.54769 16.5106 0.929688 18.4764 0.929688H48.074C50.0398 0.929688 51.6353 2.54769 51.6353 4.54937V101.615C51.6353 103.617 50.0398 105.235 48.074 105.235H47.4009V286.885C47.4009 288.887 45.8055 290.505 43.8397 290.505H22.7179C20.7521 290.505 19.1566 288.887 19.1566 286.885V105.235H18.48C16.5142 105.235 14.9187 103.617 14.9187 101.615V26.7163H7.78911V122.757C7.78911 124.759 6.19367 126.377 4.22786 126.377C2.26205 126.377 0.666609 124.759 0.666609 122.757V23.0966C0.663048 21.095 2.25849 19.477 4.2243 19.477ZM44.5128 8.16906H22.0377V97.9952H44.5128V8.16906V8.16906ZM40.2749 283.265V267.653H26.2756V283.265H40.2749ZM26.2756 260.414H40.2749V105.238H26.2756V260.414Z" fill="#FDAD19"/>
+</svg>


Intenten optimizar sus imágenes para que sean más livianas

AdrianaHY · 2020-07-30T16:03:38Z

@@ -0,0 +1,101 @@
+
+
+export const breackfast = 


Tienen un typo, es breakfast

AdrianaHY

Hicieron un excelente trabajo! Me da mucho gusto ver el avance que han tenido y estoy segura que van a lograr cosas ENORMES! Las felicito por haber hecho testing y tener un proyecto tan completo. Por otro lado les recomiendo poner MUCHO énfasis en desarrollar sus buenas prácticas, deben tener más atención al detalle, al formato de sus archivos, indentación, puntos y comas...etc! Mejorando esto tendrán un perfil mucho más completo. De nuevo, muy buen trabajo.

… into dan

Dan

danleonca and others added 30 commits June 18, 2020 13:13

inicial Router

ea8e40b

set Tables

6878450

first components

16d9b6b

new components of status of the tables

78ec151

component roles and more

f752a73

img

22429ca

work components

f8b854f

component button was modified for make it reusable

59513e5

adding all the menus

d94476b

separte controler and view

84b2a58

function and component total

99fcc1b

table status

e58b273

kitchen

f142b59

add timeOut

6bcb1ec

show all the orders in kichen

8b2322b

function close table, updates in real time, show status in component …

b6d74ff

…floor

add Edit Function

0ffbad8

get time of cooking

747da46

changes in floor

4a2628c

delete something from the order

8c05bb3

delete item from order

000338c

details design

5196c2a

add options for hamburger all funtional

f40131a

changes in newTable

6ade491

add some folders in the components

c967f9c

get folders

02a2143

testing Login

aad8354

testing floor, butun return and card burguer(only one test)

8465ebb

get Test

39677cb

change styles from Roles and TableStatus

5cb6feb

AdrianaHY reviewed Jul 30, 2020

View reviewed changes

Comment thread burguer-queen/src/components/Kitchen/Kitchen.test.js

});

AdrianaHY Jul 30, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cuiden su indentación :)

AdrianaHY reviewed Jul 30, 2020

View reviewed changes

Comment thread burguer-queen/src/utils/menus.js

@@ -0,0 +1,101 @@

export const breackfast =

AdrianaHY Jul 30, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tienen un typo, es breakfast

AdrianaHY reviewed Jul 30, 2020

View reviewed changes

shari12 and others added 6 commits August 1, 2020 15:03

pr

1b24309

changes to the observations made in the pull request

0608a0e

changes to the observations made in the pull request

b77af32

Merge branch 'master' of https://github.com/shari12/CDMX009-BurgerQueen…

da37568

… into dan

changes from pullrequest

a15c88d

Merge pull request #4 from shari12/dan

cb069a1

Dan

		@@ -0,0 +1,21 @@
		import React from 'react'

		const Form = (props) => {

Uh oh!

Conversation

shari12 commented Jul 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdrianaHY left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants