This repository was archived by the owner on Jul 11, 2026. It is now read-only.
Bren y Xel PR#11
Open
BrendaCarranco wants to merge 125 commits into
Open
Conversation
react template
app conflict
Xel menu component
Xel - menu card
card style
complete project
Bren build folder
reloadercf
suggested changes
Jul 28, 2020
reloadercf
left a comment
reloadercf
left a comment
There was a problem hiding this comment.
Bren y Xel, su proyecto esta genial y cumple con los requerimientos técnicos especificados en el readme, tengo dos recomendaciones: 1) Definir mejor el nombre asignado a los elementos (variables, clases, funciones, etc...) esto para tener una mejor claridad al momento de leer el proyecto. 2) cuidar la modularización, veo que algunos archivos superan las 100 lineas de código, esto lo pueden mejorar mudularizando sus componentes y reutilizando cuando sea necesario, lo que me agrada es que implementaron testing y usaron de manera adecuada GitHub, las invito a tener su propia versión utilizando tags.
| @@ -0,0 +1,3 @@ | |||
| node_modules/ | |||
| .vscode/ | |||
| package-lock.json | |||
There was a problem hiding this comment.
No subir la carpeta de build
Suggested change
| package-lock.json | |
| package-lock.json | |
| build/ |
| @@ -0,0 +1,45 @@ | |||
| { | |||
| "name": "template", | |||
There was a problem hiding this comment.
Completar la información
Suggested change
| "name": "template", | |
| "name": "Burguer queen", |
| <meta name="msapplication-TileImage" content="/ms-icon-144x144.png"> | ||
| <meta name="theme-color" content="#ffffff"> | ||
| <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet"> | ||
| <title>Burger Queen</title> |
Comment on lines
+1
to
+11
| import React, { useState, useEffect } from 'react'; | ||
| import { BrowserRouter, Switch, Route } from 'react-router-dom'; | ||
| import Dashboard from './components/dashboard/Dashboard.jsx'; | ||
| import Orders from './components/orders/order/Orders'; | ||
| import SignIn from './components/auth/SignIn'; | ||
| import AllOrders from './components/admon/all-orders/AllOrders'; | ||
| import Admin from './components/admon/Admin'; | ||
| import BurgerQueen from './components/BQ/BurgerQueen.jsx'; | ||
| import 'materialize-css/dist/css/materialize.min.css'; | ||
| import { firebase } from './firebase/firebaseConfig'; | ||
|
|
There was a problem hiding this comment.
Primero dependencias después componentes
Suggested change
| import React, { useState, useEffect } from 'react'; | |
| import { BrowserRouter, Switch, Route } from 'react-router-dom'; | |
| import Dashboard from './components/dashboard/Dashboard.jsx'; | |
| import Orders from './components/orders/order/Orders'; | |
| import SignIn from './components/auth/SignIn'; | |
| import AllOrders from './components/admon/all-orders/AllOrders'; | |
| import Admin from './components/admon/Admin'; | |
| import BurgerQueen from './components/BQ/BurgerQueen.jsx'; | |
| import 'materialize-css/dist/css/materialize.min.css'; | |
| import { firebase } from './firebase/firebaseConfig'; | |
| import React, { useState, useEffect } from 'react'; | |
| import 'materialize-css/dist/css/materialize.min.css'; | |
| import { firebase } from './firebase/firebaseConfig'; | |
| import { BrowserRouter, Switch, Route } from 'react-router-dom'; | |
| import Dashboard from './components/dashboard/Dashboard.jsx'; | |
| import Orders from './components/orders/order/Orders'; | |
| import SignIn from './components/auth/SignIn'; | |
| import AllOrders from './components/admon/all-orders/AllOrders'; | |
| import Admin from './components/admon/Admin'; | |
| import BurgerQueen from './components/BQ/BurgerQueen.jsx'; | |
| return unsuscribe; | ||
| }, []); | ||
|
|
||
| const [data, setData] = useState({ |
There was a problem hiding this comment.
Suggested change
| const [data, setData] = useState({ | |
| let [data, setData] = useState({ |
| .then(data => { | ||
| setBreakfast(data.desayunos); | ||
| }); | ||
| }, [] |
There was a problem hiding this comment.
Precaucion con esta linea
Suggested change
| }, [] | |
| }, [] |
Comment on lines
+3
to
+17
| const FoodItem = ({ item, id, price, quantity, addOrder }) => ( | ||
| <div className='col m6 space'> | ||
| <div className='card general' onClick={() => { addOrder({ item, price, id, quantity }); }}> | ||
| <div className="card-image row food-image"> | ||
| <img src={`/img/products/${id}.png`} className='col m6 img-icon item' alt='food-img' /> | ||
| </div> | ||
| <div className='card-content white-text center-align'> | ||
| <div> | ||
| <p className='info' name='item'>{item}</p> | ||
| <p className='info' name='price'>$ {price}.00 </p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
esto pueden modularizarlo en un componente
| padding-left: 50px !important; | ||
| } | ||
|
|
||
| .icn{ |
There was a problem hiding this comment.
definir mejor
Suggested change
| .icn{ | |
| .icn{ |
| </thead> | ||
| <tbody> | ||
| { | ||
| newProduct.map((item) => ( |
There was a problem hiding this comment.
Cada que haces un .map() tienes que usar key en los elementos renderizáados
Suggested change
| newProduct.map((item) => ( | |
| newProduct.map((item) => ( |
|
|
||
| const updateDoc = async (e) => { | ||
| e.preventDefault(); | ||
| console.log(orderSelected.id); |
There was a problem hiding this comment.
su consola debe de estar limpia
Suggested change
| console.log(orderSelected.id); | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.