Fix PassportTest and improve scoping#1233
Open
labkey-jeckels wants to merge 3 commits into
Open
Conversation
vagisha
reviewed
Jun 14, 2026
|
|
||
| /** | ||
| * Container-scoping integration tests for {@link TargetedMSController} actions that resolve an object by a | ||
| * global id. Each test sets up the same object in one folder and confirms the action rejects a request that addresses |
Collaborator
There was a problem hiding this comment.
Comment truncated? Should it be "...that addresses the object through a different folder."?
Contributor
Author
There was a problem hiding this comment.
Thanks. Fixed.
vagisha
reviewed
Jun 14, 2026
| @Test | ||
| public void auditLogExtraInfoIsContainerScoped() throws Exception | ||
| { | ||
| UnitTestUtil.cleanupDatabase(DOC_GUID); |
Collaborator
There was a problem hiding this comment.
Is this redundant with @After cleanupAuditLog()?
Contributor
Author
There was a problem hiding this comment.
Largely, yes. Better to mark that method as both Before and After and remove this call. Done.
vagisha
reviewed
Jun 14, 2026
| public void waitForElementsAtLeast(final Locator loc, final int count) | ||
| { | ||
| waitFor(() -> loc.findElements(getDriver()).size() >= count, WAIT_FOR_JAVASCRIPT); | ||
| assertTrue("Element not present at least the expected number of times", loc.findElements(getDriver()).size() >= count); |
Collaborator
There was a problem hiding this comment.
loc.findElements(getDriver()).size() is getting called twice.
Contributor
Author
There was a problem hiding this comment.
True, but one is inside the lambda. We could reuse the result but I think it's a bit cleaner (and reasonable) to check again outside the lambda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
PassportTest needs an update to expect the updated data being pulled dynamically from UniProt
Changes