Bump eslint from 9.39.2 to 10.9.0 - #51
Conversation
dependabot
Bot
added
dependencies
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.9.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.9.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.9.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
787ddc4 to
dec4af1
Compare
|
Not merging — ESLint 10 has no compatible Reproduced locally: This is why the From the npm registry, Worth knowing: this whole toolchain is currently inert. There is no Two ways out, both cheaper than waiting: wire up a working flat config on versions that support ESLint 10 and TS 7, or drop the unused eslint packages and close this. Either unblocks #47 at the same time. Flagging for a human decision rather than picking one — removing dev dependencies is beyond a dependency bump. Generated by Claude Code |
|
Correcting my previous comment on one point — it pointed at a release that will not help. I said ESLint 10 support "first appears in So there is no This makes the "worth knowing" part of the earlier comment the actual path forward rather than a side note. There is no Two viable options, and "wait for upstream" is not one of them:
Note that option 2 unblocks this PR but not #47: Still not merging, and still flagging for a human rather than removing dev dependencies myself. Generated by Claude Code |
#64) `npm run lint` has never worked (#63). The script existed from the start but no config ever did, so eslint exited non-zero on every invocation, and nothing caught it because no workflow ran it. Fixing that also unblocks #51. Dependabot's eslint 9 -> 10 bump was failing at `npm ci` with ERESOLVE, not at any check step: eslint-plugin-react@7.37.5 peers `eslint ^3 || ... || ^9.7` and has no release that accepts 10 (the `next` tag is a stale 7.8.0-rc.0 peering ^3 || ^4). The plugin was also dead weight - with no config, nothing had ever referenced it. Dropping it and moving @typescript-eslint to ^8.69.0, the first line peering `^8.57 || ^9 || ^10`, leaves nothing in the tree capping eslint's major. The new config is deliberately not built on @eslint/js, which peers a single eslint major and would recreate this exact failure on the next bump. Getting to a clean run needed some dead code removed: unused imports, two catch bindings that were never read, and `currentPresentationPath` in both Windows backends, which was written twice and read never (macos.ts genuinely reads it as a fallback, so it stays there). `require-atomic-updates` is set to 'warn' rather than disabled - it flags seven pre-existing interleaving hazards in the automation backends that need a real PowerPoint install to fix safely. CI runs lint now, between install and typecheck. A lint script no job runs is how this went unnoticed for the life of the repo. Finally, dependabot grouping, because #51 was one of four PRs failing the same way: a solo bump of a package whose peers are pinned to a sibling's major can never resolve alone. #49 and #50 are the clearest case - one bumps vite to 8, the other bumps @vitejs/plugin-react to a version requiring vite 8, and each fails precisely because the other is a separate PR. Two of the four remain blocked upstream and are not addressed here: #47 (typescript 7) waits on @typescript-eslint, which still peers `<6.1.0`, and #49/#50 wait on electron-vite 6 leaving beta, since 5.0.0 peers `vite ^5 || ^6 || ^7`. Grouped, those now sit still instead of failing every week. Refs #63, #51 Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
|
Superseded by #65. |
1 participant
Bumps eslint from 9.39.2 to 10.9.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
c27bc9210.9.0fa831d9Build: changelog update for 10.9.0899dbf1chore: update github/codeql-action action to v4.37.7 (#21243)08de88efeat: handle underflow in no-loss-of-precision (#21218)9ef407adocs: use eslint.config.* wherever config file names are listed (#21216)9aa3873chore: update ecosystem plugins (#21235)2ba3025fix: prevent unsafeno-varautofix with hoisted functions (#21213)dc1e7a8chore: update ecosystem plugins (#21208)87f66f4docs: Update README8e69622fix: Prevent no-var autofix when var is shadowed by catch parameter (#21204)