Sample workflow management by louisdussarps · Pull Request #65 · LaWebcapsule/orbits

louisdussarps · 2025-07-18T10:05:57Z

Change description

Description here

Type of change

Bug fix (fixes an issue)
New feature (adds functionality)

Related issues

Checklists

Development

Lint rules pass locally
Application changes have been tested thoroughly
Automated tests covering modified code pass

Security

Security impact of change has been considered
Code follows company security practices and guidelines

Code review

Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
reviewers assigned

louisdussarps · 2025-07-18T10:07:58Z

+    }
+
+    async main(){
+        console.log(`url ${JSON.stringify(API_ADDRESS)} is buyStock`);


utiliser internalLog

louisdussarps · 2025-07-18T10:08:22Z

+            body: JSON.stringify({ stock_price: this.argument.price })
+        };
+        const response = await fetch(API_ADDRESS + 'buyStock', requestOptions);
+        this.result.stockData = await response.json();


utiliser setResult plutôt

ok je l'avais laissé comme cela car la dernière fois tu m'as dit de laisser.

oui, pas crucial sur ce point

louisdussarps · 2025-07-18T10:09:15Z

+    const workflow = new TradingWorkflow();
+    await workflow.save();
+    await Action.trackActionAsPromise(workflow);
+    console.log(await workflow.getLogs());


getLogs() non fonctionnel

c'était repris sur la demo cdk8s

hmm, sûr ? je le vois ni sur cdk8s ni sur cdk

louisdussarps · 2025-07-18T10:10:03Z

+
+    async define(){
+        const resultCheckStockPrice = await this.do("check-stock-price", new CheckStockPriceAction());
+        const stockPrice: StockPriceResultObj = resultCheckStockPrice.stockPrice as StockPriceResultObj;


typage a priori superflu

louisdussarps · 2025-07-18T10:10:55Z

+        const buyOrSellRecommendation : string = resultGenerateBuySellRecommendationAction.buyOrSellRecommendation
+        console.log(`Got recommendation based on price: ${buyOrSellRecommendation}`)
+
+        let result: StockTransaction = {


j'aurais plutôt mis les return à l'intérieur du if, qu'un result isolé comme ça

dans tous les cas let result:.. suffit, pas besoin d'initialiser la valeur

yep, j'aime généralement cette forme de code cela permet de pouvoir modifier result comme on le veut et éviter des erreurs.

Dans ce cas
let result : StockTransaction suffit, pas besoin de l'affection non ?

louisdussarps · 2025-07-18T10:13:30Z

+import { JSONObject } from "../../../../../packages/services/src/utils";
+
+
+export class BuyStockAction extends Action {


ça serait bien d'avoir une version qui utilise l'api asyncrhone des lambdas pour toutes ces actions. ça permettrait d'illustrer le watcher()

Je veux bien plus d'information sur ce point

quoi comme informations ? 🤔

faudrait se baser sur cloudwatch pour récupérer le résultat de la fonction en fonction d'un requestId

louisdussarps · 2025-07-21T08:55:29Z

@@ -0,0 +1 @@
+API_ADDRESS=https://f4h881vcjl.execute-api.eu-west-3.amazonaws.com/prod/


ce fichier est aussi dans les .gitignore

louisdussarps · 2025-07-21T08:56:02Z

+  "dependencies": {
+    "@orbi-ts/core": "latest",
+    "@orbi-ts/fuel": "latest",
+    "dotenv": "^17.0.1",


on a vraiment besoin de dotenv dans les dépendances ?

louisdussarps

quelques petites remarques ; il manque plus grand chose

louisdussarps · 2025-07-21T14:32:56Z

+
+## Use Case
+
+In this blog post, we revisit the example of orchestrating a banking transaction. This canonical example was provided by [AWS Step Functions](https://docs.aws.amazon.com/step-functions/latest/dg/welcome.html) and [Temporal](https://temporal.io/blog/temporal-replaces-state-machines-for-distributed-applications). Readers can refer to these articles to compare the syntax and ease of implementation offered by each tool.


pas le bon lien pour AWS ?

louisdussarps · 2025-07-21T14:33:24Z

+                price:stockPrice.stock_price
+            })); 
+
+        const buyOrSellRecommendation : string = resultGenerateBuySellRecommendationAction.buyOrSellRecommendation


pas besoin du string ici ?

louisdussarps · 2025-07-21T14:34:07Z

+- **Atomic actions**: Each business step is an independent and testable action
+- **Conditional branching**: The workflow flow can diverge based on data (buy or sell). It does not differ from standard TypeScript code.
+- **Extensibility**: We can easily add steps, compensation logic, monitoring
+- **Resilience**: Recovery after crash, state management, built-in observability


il manque un verbe ici en comparaison des autres tirets

louisdussarps · 2025-07-21T14:35:42Z

+- Takes a **typed input** (price)
+- Calls a remote API in an encapsulated manner
+- **Returns a state - ActionState.SUCCESS**, ready to be recorded and resumed
+- Handles **errors by default via a state - ActionState.ERROR**


il faudrait surtout expliquer/trouver le moyen d'introduire le ActionState.IN_PROGRESS non ? Sinon on voit pas pourquoi le state de l'action serait pas le state de la promise qui constitue le main()

Proposition :

Alternative : return ActionState.IN_PROGRESS, avoid waiting for the API response delegating to the watcher the responsibility of determining the final state of the action.

louisdussarps · 2025-07-21T14:37:02Z

+For your critical processes — e-commerce, finance, logistics, etc. — **adopting such an approach will significantly reduce your bug rate and inconsistencies**.
+
+---
+


ça serait bien de rediriger quelque part, soit à la fin, soit dès le début, vers le sample, pour qu'on puisse voir le code source directement dans github et pourquoi pas le tester

louisdussarps · 2025-07-21T14:38:34Z

@@ -0,0 +1,3 @@
+export const API_ADDRESS = process.env['API_ADDRESS'];
+
+console.log(API_ADDRESS)


enlever le console.log ?

louisdussarps · 2025-07-21T14:39:42Z

+ActionRuntime.activeRuntime.waitForBootstrap.then(async ()=>{
+    const workflow = new TradingWorkflow();
+    await workflow.save();
+    await Action.trackActionAsPromise(workflow);


tu veux pas afficher le résultat à la fin ? Sinon le await ne sert pas à grand chose

d'ailleurs trackActionAsPromise retourne le résultat

ldechamps added 2 commits July 17, 2025 16:51

feat: sample ttrading workflow

5d3e3f5

feat: blog post

b0112b4

louisdussarps commented Jul 18, 2025

View reviewed changes

louisdussarps commented Jul 21, 2025

View reviewed changes

ldechamps added 2 commits July 21, 2025 14:45

fix: udpate version

762f820

fix: rename page

8b6ad07

louisdussarps commented Jul 21, 2025

View reviewed changes

ldechamps added 5 commits July 21, 2025 16:54

fix: remove console.log

41feae1

fix: AWS Step Functions url in blog

2edebf1

fix: verbs coherence

e604b5a

fix: remove string & display workflow result

f2d24c8

feat: view source code

6d5fcb9

ldechamps closed this Jul 22, 2025

		import { JSONObject } from "../../../../../packages/services/src/utils";


		export class BuyStockAction extends Action {

		@@ -0,0 +1 @@
		API_ADDRESS=https://f4h881vcjl.execute-api.eu-west-3.amazonaws.com/prod/ No newline at end of file


		## Use Case

		In this blog post, we revisit the example of orchestrating a banking transaction. This canonical example was provided by [AWS Step Functions](https://docs.aws.amazon.com/step-functions/latest/dg/welcome.html) and [Temporal](https://temporal.io/blog/temporal-replaces-state-machines-for-distributed-applications). Readers can refer to these articles to compare the syntax and ease of implementation offered by each tool.

		For your critical processes — e-commerce, finance, logistics, etc. — adopting such an approach will significantly reduce your bug rate and inconsistencies.

		---

		@@ -0,0 +1,3 @@
		export const API_ADDRESS = process.env['API_ADDRESS'];

		console.log(API_ADDRESS)

Uh oh!

Conversation

louisdussarps commented Jul 18, 2025

Change description

Type of change

Related issues

Checklists

Development

Security

Code review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louisdussarps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants