Skip to content

Fix blocked list scrolling and incognito image - #29

Merged
LTDigor merged 1 commit into
mainfrom
codex/fix-list-scroll-incognito-image
Jul 19, 2026
Merged

LTDigor merged 1 commit into
mainfrom
codex/fix-list-scroll-incognito-image

Conversation

@LTDigor

@LTDigor LTDigor commented Jul 19, 2026

Copy link
Copy Markdown
Owner

What changed

  • constrain the expanded blocked-sites list to the grid space below its header, so the final entries remain reachable
  • preserve the block page image URL resolved by the current browser context instead of replacing it with a potentially mismatched dynamic extension URL
  • add regression coverage for both failures

Root cause

The list content claimed 100% of the card height in addition to the fixed header, so the card clipped its bottom. The block page also replaced its context-correct image URL with runtime.getURL(), which can point at a different dynamic resource host in split incognito contexts.

Validation

  • npm test (83 tests)
  • npm run package
  • isolated-browser UI verification for full list scrolling and blocked-image rendering

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9efce5e8-eeab-44b0-a640-55b556b2d925

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LTDigor
LTDigor merged commit 360cf58 into main Jul 19, 2026
3 checks passed
@LTDigor
LTDigor deleted the codex/fix-list-scroll-incognito-image branch July 19, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant