Fix error array rotation bug#184
Merged
Merged
Conversation
Coverage Report for CI Build 27256796816Coverage decreased (-0.01%) to 89.031%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Contributor
Author
|
Not sure why coveralls is saying this decreased the coverage. Nothing here touched fitter.py where it's complaining. |
Collaborator
|
More importantly the tests are passing. I am happy to merge the MR now if you're done. |
Contributor
Author
|
Yep this one's pretty straightforward. I'm ready to go on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the image is rotated, errors should be rotated too. Currently the
if rotated:path draws onimage.errrather thanimage.err_rotated(to go withimage.data_rotated) as it should. This PR fixes it.