Repository navigation
Add validations for new PRs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f71e1da
Add validations for new PRs
andres-javier-lopez 229fa04
Rename template
andres-javier-lopez 948cec4
Update changelog
andres-javier-lopez d087352
Update .github/workflows/validate-pr.yml
andres-javier-lopez b3f4ba8
Fix github action
andres-javier-lopez 5ba0f01
Remove github action from validation
andres-javier-lopez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # GitHub Copilot custom instructions for assistant_core contributors | ||
| # This file provides guidance to GitHub Copilot (and human reviewers) about | ||
| # repository conventions and PR requirements. | ||
|
|
||
| project: assistant_core | ||
|
|
||
| instructions: | ||
| - When suggesting code changes or PR descriptions, ensure the contributor adds | ||
| a concise CHANGELOG.md entry under the NEXT section that explains what | ||
| changed and why. | ||
|
|
||
| - Remind contributors to follow `CONTRIBUTING.md`: | ||
| - Run tests and add tests for behavior changes. | ||
| - Run formatters and linters (make format / make lint). | ||
| - Update documentation where applicable. | ||
|
|
||
| - If the suggestion touches public APIs or behavior, encourage adding | ||
| typed signatures and small unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <!-- | ||
| Use this template for new pull requests. It codifies the conventions in CONTRIBUTING.md | ||
| and makes it easy for reviewers to see what's required. | ||
| --> | ||
|
|
||
| ## Description | ||
|
|
||
| A short description of the change. Link to any relevant issue(s) or RFC. | ||
|
|
||
| ## Type of change | ||
| - [ ] Bugfix | ||
| - [ ] New feature | ||
| - [ ] Documentation update | ||
| - [ ] Refactor | ||
| - [ ] Chore | ||
|
|
||
| ## Checklist | ||
| Please run through the checklist and mark the items off before requesting review. These mirror the project's `CONTRIBUTING.md` guidelines. | ||
|
|
||
| - [ ] Tests added/updated for changes in behavior | ||
| - [ ] Linter/formatter run (make format / make lint) | ||
| - [ ] Documentation updated (if applicable) | ||
| - [ ] CHANGELOG.md updated with a short entry describing the change (Required) | ||
|
|
||
| If your change requires special setup or steps to verify, include them below. | ||
|
|
||
| ## How to test | ||
| Describe steps to reproduce or to run the test suite for the change. | ||
|
|
||
| ## Additional context | ||
| Any additional information for reviewers, e.g. performance notes or tradeoffs. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.