fix: round lightning invoice amounts to nearest satoshi#62
Merged
Conversation
Some Lightning wallets don't handle milli-sats amounts correctly. Round invoice amounts up to the nearest satoshi to ensure wallet compatibility while avoiding underpayment issues. The rounding is applied in two places: 1. In the pricing engine (get_amount_and_rate) for the base amount 2. At invoice creation for the final amount+tax sum Closes #61
v0l
force-pushed
the
feat/round-lightning-invoice-amounts
branch
from
February 22, 2026 18:07
bb1bbcc to
962e40d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
round_to_sat()helper function to round milli-satoshi amounts up to the nearest satoshiSome Lightning wallets don't handle milli-sats amounts correctly. This change rounds invoice amounts to whole satoshis (rounding up to avoid underpayment).
Closes #61