-
Notifications
You must be signed in to change notification settings - Fork 1
Add email required validation and email verification flow #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7438e6f
Initial plan
Copilot deebd2d
Add email verification flow and make email required for email notific…
Copilot 32ac543
Update API documentation for email verification flow
Copilot 4136ea2
Address review feedback: email required, HTML verify page, shared sen…
Copilot 952923f
Use mustache for email.html, add verify-email.html template, make ema…
Copilot 2505af8
Fix email verification: migration timestamp, clickable links, SMTP er…
v0l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Database Migrations | ||
|
|
||
| ## Timestamp Rules | ||
|
|
||
| **CRITICAL:** Migration filenames must have unique timestamps (full 14-digit `YYYYMMDDHHMMSS`). Before creating or modifying a migration: | ||
|
|
||
| 1. **Check existing timestamps** — Run `ls lnvps_db/migrations/` and verify your full timestamp doesn't conflict | ||
| 2. **After rebasing** — If your branch adds migrations, check that the timestamps don't collide with migrations added to master | ||
| 3. **Use the current timestamp** — Generate with `date +%Y%m%d%H%M%S` | ||
|
|
||
| Migration format: `YYYYMMDDHHMMSS_description.sql` | ||
|
|
||
| Example conflict to avoid: | ||
| ``` | ||
| 20260219000000_cpu_type.sql # from master | ||
| 20260219000000_email_verification.sql # CONFLICT — same full timestamp! | ||
| ``` | ||
|
|
||
| Fix by using a completely unique timestamp: | ||
| ``` | ||
| 20260219000000_cpu_type.sql | ||
| 20260221120000_email_verification.sql # different date AND time | ||
| ``` | ||
|
|
||
| ## Migration Best Practices | ||
|
|
||
| - Use `NOT NULL DEFAULT <value>` for new columns to avoid breaking existing rows | ||
| - Test migrations against a database with production-like data | ||
| - Never modify a migration that has already been applied to any environment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.