Add a raster favicon fallback

[LJAYi]

Summary

• add a 64 × 64 PNG favicon fallback while retaining the SVG favicon
• document which brand assets are vector and which are fixed-size PNG exports
• cover both favicon declarations in the web end-to-end test

Validation

• pnpm --filter @mmd2pptx/web e2e (10 passed)

Follow-up to CodeRabbit feedback on #13.

Summary by CodeRabbit

• New Features

  • Added a 64×64 PNG favicon for browsers that don’t support SVG favicons.
  • Retained the existing SVG favicon for supported browsers.

• Documentation

  • Updated brand asset documentation to describe the new PNG favicon and clarify raster versus SVG usage.

[coderabbitai]

Warning

Review limit reached

@LJAYi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3282be38-7add-4811-af45-0c325887000e

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0facb and e7edff6.

📒 Files selected for processing (1)

• apps/web/tests/e2e/workbench.spec.ts

📝 Walkthrough

Walkthrough

The web app now includes a 64×64 PNG favicon fallback. The end-to-end test validates both favicon formats. Brand documentation describes the new raster asset and its intended use.

Changes

Favicon fallback

Layer / File(s)	Summary
Favicon integration and validation apps/web/index.html, apps/web/tests/e2e/workbench.spec.ts	The HTML adds a PNG favicon link. The end-to-end test verifies the SVG and PNG favicon paths.
Brand asset documentation docs/brand.md	The brand asset table lists favicon.png. The text distinguishes SVG assets from raster exports.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• LJAYi/mmd2pptx#13: Adds related web favicon integration and brand documentation changes.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a raster favicon fallback.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/brand-review-followups

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

apps/web/tests/e2e/workbench.spec.ts (1)

62-65: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Assert the PNG favicon size.

The HTML declares sizes="64x64", and the brand documentation defines the PNG as 64 × 64. This test checks the MIME type and path but not the size declaration. Add the missing assertion.

Proposed test assertion

   await expect(page.locator('link[rel="icon"][type="image/png"]')).toHaveAttribute(
     "href",
     "./favicon.png",
   );
+  await expect(page.locator('link[rel="icon"][type="image/png"]')).toHaveAttribute(
+    "sizes",
+    "64x64",
+  );

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/tests/e2e/workbench.spec.ts` around lines 62 - 65, The favicon
assertion for the PNG icon link is missing a check for the sizes attribute. Add
a toHaveAttribute assertion to the same expect statement to verify that the
sizes attribute equals "64x64", which matches the HTML declaration and brand
documentation requirement for the favicon dimensions.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/web/tests/e2e/workbench.spec.ts`:
- Around line 62-65: The favicon assertion for the PNG icon link is missing a
check for the sizes attribute. Add a toHaveAttribute assertion to the same
expect statement to verify that the sizes attribute equals "64x64", which
matches the HTML declaration and brand documentation requirement for the favicon
dimensions.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ad5e9f2-1d3e-4009-8016-f4501571fcb0

📥 Commits

Reviewing files that changed from the base of the PR and between ce6c8c8 and 0e0facb.

⛔ Files ignored due to path filters (1)

• apps/web/public/favicon.png is excluded by !**/*.png

📒 Files selected for processing (3)

• apps/web/index.html
• apps/web/tests/e2e/workbench.spec.ts
• docs/brand.md