fix(ci): skip tidy-check in nightly FSC update workflow - #2004
Open
adecaro wants to merge 1 commit into
Open
Conversation
adecaro
force-pushed
the
nightly-fsc-update-fix
branch
from
July 27, 2026 16:53
b648971 to
bf33e1e
Compare
adecaro
force-pushed
the
nightly-fsc-update-fix
branch
from
July 28, 2026 08:51
bf33e1e to
50fa724
Compare
tidy-check flags any uncommitted go.mod/go.sum change as untidy via git diff against HEAD. The nightly FSC bump workflow deliberately rewrites go.mod/go.sum to a new fabric-smart-client version (and already runs 'make tidy' via update-dep) before make checks runs, so the git-diff heuristic always fails there even though the modules are genuinely tidy. Add a checks-no-tidy target that runs every other check and switch the nightly workflow to use it, leaving tidy-check and the regular checks target unchanged for normal PR usage. Fixes #2003 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
nightly-fsc-update-fix
branch
from
July 28, 2026 17:59
50fa724 to
ddacd38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tidy-checkflags any uncommittedgo.mod/go.sumchange as untidy by diffing against git HEAD. The nightly FSC bump workflow deliberately rewrites those files to a newfabric-smart-clientversion (and already runsmake tidyitself viaupdate-dep) beforemake checksruns, so the git-diff heuristic fails unconditionally on every nightly run even though the modules are genuinely tidy.checks-no-tidytarget tochecks.mk(same check list aschecks, minustidy-check) and switchnightly-fsc.yml's "Run checks" step to use it.tidy-checkand the regularcheckstarget are unchanged for normal PR/local usage.Fixes #2003
Test plan
make checks-no-tidyexits 0 and skips the tidy-check section entirelymake checksstill exits 0 and prints "✓ All Go modules are tidy." (no regression for normal usage)make lint-auto-fix— 0 issues in every module