Add SecretPoint. Improve SecretScalar - #92
Merged
Merged
Conversation
maurges
commented
Jun 17, 2026
maurges
commented
Contributor
- SecretPoint is like SecretScalar but for points
- Add Zeroize instance to scalar and point byte representations
- SecretPoint and SecretScalar provide methods to get secret bytes
Signed-off-by: maurges <git@morj.men>
Signed-off-by: maurges <git@morj.men>
Signed-off-by: maurges <git@morj.men>
Signed-off-by: maurges <git@morj.men>
Signed-off-by: maurges <git@morj.men>
For some reason cargo build --no-default-features didn't fully check every definition? Signed-off-by: maurges <git@morj.men>
maurges
marked this pull request as ready for review
June 17, 2026 14:33
survived
reviewed
Jun 17, 2026
Signed-off-by: maurges <git@morj.men>
survived
reviewed
Jun 23, 2026
Signed-off-by: maurges <git@morj.men>
Signed-off-by: maurges <git@morj.men>
survived
reviewed
Jun 26, 2026
Signed-off-by: maurges <git@morj.men>
Signed-off-by: maurges <git@morj.men>
Contributor
Author
|
Forgot to signoff one commit, had to force push the latest two |
survived
previously approved these changes
Jul 13, 2026
survived
left a comment
survived
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Do you want to cut a release with those changes? Then we need a version bump + changelog update
Contributor
Author
|
Sure, let's cut one out |
Signed-off-by: maurges <git@morj.men>
survived
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.