Zarr codec - #10
Merged
Merged
Conversation
It's simpler for the user, and it isn't meant to be chained with other BytesBytes codecs anyway.
Basic functionality and guards should be in the main library. Codec-specific tests can be isolated.
Total samples was prepended to the compressed e1 bytes in the codec, which changes the storage format compared to the original (invalid e1 data). Instead, get the total samples from the Zarr chunk spec, and test that the compressed bytes are exactly the same to the C library output (valid e1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Zarr codec and restructured into a package. All imports should remain unchanged, though exception types may be more specific than beore.