Migration towards a python package version. - #20
Open
nhamilakis wants to merge 3 commits into
Open
Conversation
Author
|
I wanted to keep it as backwards compatible as possible, but we could make the checkpoint argument more explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to simplify usage of the VTC inference pipeline.
This adds two different modes of execution that use the same code:
Command line :
With (almost) the same arguments as before.
A Python API mode :
The model & resource (thresholds & config) is handled fully by huggingface cache, so there is no need to keep those in the repo, their download is automatic and is referenced by the following mapping:
These map to a commit on the model repository.
For backward compatibility, a local path can still be passed instead of a version for config/checkpoint & threshold files.
This pull request is meant to replace #17, which seems to have been a bit forgotten.