Replace unpopulated Board card with Avg HDD card - #6
Merged
Conversation
board_c is null on this AST2600 BMC, so the Board card was either a dead --deg or hidden (leaving an ugly gap). Replace it with an Avg HDD card: mean across the spinning drives (NVMe excluded), computed client-side from the drives array /status already sends, coloured on the same drive thresholds as Max HDD. Always populated, and cooling-relevant (max vs avg shows whether it is a couple hot drives or the whole pool). Keeps the defensive [hidden] CSS rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Ace: the hidden Board card left an ugly gap, and board_c is null on this BMC anyway. Replace it with an always-populated Avg HDD card (mean across spinning drives, NVMe excluded, computed client-side from the drives array /status already sends, coloured on the drive thresholds). Max vs Avg now shows whether heat is a couple hot drives or the whole pool. 51 tests green.