Custom default sort direction - #200
Closed
ezra-obiwale wants to merge 4 commits into
Closed
Conversation
|
Hello - I would really love to see this PR implemented. I just got a request from a user to implement this functionality and this PR would resolve. Thanks for your work! |
2 tasks
|
This is already possible by passing direction as an associative array to the third parameter: $columnSpecificData['name'] = ['direction' => 'desc'];
@sortablelink('name', 'Name', $columnSpecificData['name'])
$columnSpecificData['other'] = ['direction' => 'asc'];
@sortablelink('other', 'Other', $columnSpecificData['other']) |
Author
|
@robbielove I tested it as you mentioned above however, the direction was still being overridden by the determined direction. I've updated this PR to fix that. |
Author
|
Cool. Shutting this down then. Could you maybe see about merging one of those PRs? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures overriding the direction in the query parameter works as expected.