Skip to content

fix(test): restore cross-platform quality gates - #1257

Open
SunwardL wants to merge 2 commits into
KunAgent:developfrom
SunwardL:codex/fix-quality-gate-baseline
Open

fix(test): restore cross-platform quality gates#1257
SunwardL wants to merge 2 commits into
KunAgent:developfrom
SunwardL:codex/fix-quality-gate-baseline

Conversation

@SunwardL

@SunwardL SunwardL commented Aug 31, 2026

Copy link
Copy Markdown

Summary / 概要

  • Restore the cross-platform quality-gate baseline after rebasing onto the latest develop.
  • Fix stale test expectations, Windows-specific failures, and cross-platform path handling.
  • Correct the OpenCode anonymous free-model catalog and unblock every PR packaging gate.
  • Keep the quality-gate work independent from the memory-foundation PR.

Why / 背景

The branch had diverged from the latest develop. After rebasing, the full validation exposed stale fixtures, Windows cleanup races, host-dependent path behavior, stale provider data, packaging bloat, and packaged handoff/health-check issues.

This PR fixes those problems so subsequent memory-module changes can be reviewed on a clean baseline.

Changes / 变更

  • Restore provider catalog and provider settings test coverage.
  • Keep OpenCore Free limited to current, non-deprecated, zero-cost models that support anonymous Chat Completions; block incompatible Responses-only imports.
  • Treat disconnected Graph streams as recoverable.
  • Fix Windows process cleanup and installer recovery metadata.
  • Make the Windows update health renderer use the preload's real startup IPC channel.
  • Start the packaged health Runtime through Electron's Node mode, isolate its Service Manager/data plane, and tear both processes down after the probe.
  • Bound the internal update health contract to 120 seconds, use a dynamic loopback port, fail immediately on Runtime exit, and preserve phase/Runtime/Manager diagnostics without exposing tokens.
  • Prevent unnecessary rewrites of semantically unchanged Kun configuration.
  • Fix cross-platform path handling for GitHub CLI, bundled skills, Chromium cookies, PPT and Git review.
  • Update test fixtures for the current extension API, proxy routing and provider-probe contracts.
  • Align the latest Board route, retired perspective panel, app keep-awake defaults, Runtime version identity, Todo document-edit semantics, and GitHub MCP settings IPC schema.
  • Split hybrid-store migration and usage helpers to satisfy the 700-line file limit.
  • Split child result helpers and protected approval contracts introduced by the latest develop so every tracked source remains below 700 lines.
  • Improve Windows test cleanup reliability.
  • Remove the duplicated bundled Gemini CLI dependency; Kun now discovers an official system installation.
  • Correct the recycled-PID handoff fixture so an unrelated helper is not advertised as a Runtime data-directory owner, and preserve process output on future smoke failures.

Media / 截图或录屏

  • N/A — no user-facing visual redesign.

Tests / 测试

  • npm run typecheck
  • npm run lint — 0 errors, 30 pre-existing React Hooks warnings
  • npm run build
  • npm run check:file-lines
  • Provider, settings, update-health, official CLI, and TUI targeted Vitest coverage
  • Packaged handoff Node contract tests
  • Packaged recycled-PID handoff smoke on macOS arm64
  • Local Electron-as-Node Runtime /health and thread create/read/delete smoke with an isolated Service Manager
  • GitHub PR checks will re-run against commit ae5635b39335aafcf4e39b9bec756818b2b3716b rebased on d0e3103390257bf15a0942f33ca2a78f4b99c575.

Validation / 验证

  • I agree that this contribution is submitted under the Contributor License Agreement.
  • Local tests passed
  • Typecheck passed
  • Build passed
  • Logic tests added or updated

Notes / 备注

  • Base: KunAgent/Kun:develop
  • Head: SunwardL/Kun:codex/fix-quality-gate-baseline
  • Commit: ae5635b39335aafcf4e39b9bec756818b2b3716b

@SunwardL
SunwardL force-pushed the codex/fix-quality-gate-baseline branch from 924a0f7 to 3c4e295 Compare September 1, 2026 04:12
@XingYu-Zhong
XingYu-Zhong force-pushed the codex/fix-quality-gate-baseline branch 4 times, most recently from 3a05419 to 48e63e5 Compare September 1, 2026 08:19
XingYu-Zhong
XingYu-Zhong previously approved these changes Sep 1, 2026

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and validated after the quality-gate, provider-catalog, packaging, handoff, and Windows health-bootstrap fixes. Approving commit 48e63e5 pending required checks.

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after validating the final health-first entry routing and stable out/main bundle-root normalization at commit 32d24fd.

@XingYu-Zhong
XingYu-Zhong force-pushed the codex/fix-quality-gate-baseline branch from 32d24fd to a97bb39 Compare September 1, 2026 09:41
XingYu-Zhong
XingYu-Zhong previously approved these changes Sep 1, 2026

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at commit a97bb39 after validating health-first routing and stable main bundle-root resolution for split chunks.

XingYu-Zhong
XingYu-Zhong previously approved these changes Sep 1, 2026

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at commit f1cbdeb after validating combined ExecShellAsUser health arguments, split bundle roots, and all local checks.

XingYu-Zhong
XingYu-Zhong previously approved these changes Sep 1, 2026

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at commit b0b57a9 after removing the health bootstrap import cycle and validating the compiled chunk graph.

@XingYu-Zhong
XingYu-Zhong force-pushed the codex/fix-quality-gate-baseline branch 2 times, most recently from 9411540 to 64f3804 Compare September 1, 2026 15:42
XingYu-Zhong
XingYu-Zhong previously approved these changes Sep 1, 2026

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after rebasing onto the latest develop and validating the bounded Windows update-health Runtime fix.

XingYu-Zhong
XingYu-Zhong previously approved these changes Sep 1, 2026

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after aligning the latest develop quality-gate contracts.

@SunwardL
SunwardL force-pushed the codex/fix-quality-gate-baseline branch from 169199b to fbb3e19 Compare September 1, 2026 16:46
@SunwardL
SunwardL force-pushed the codex/fix-quality-gate-baseline branch from fbb3e19 to bc2a145 Compare September 1, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants