Implement json style arguments for behaviors in generate-tables command #46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import json | ||
| from pathlib import Path | ||
| from typing import Dict, Any, List | ||
|
|
||
|
|
||
| def load_json(source: Path | str | None) -> Dict[str, Any] | List[Any] | None: | ||
| """Load JSON from a file path, JSON string, or return None. | ||
|
|
||
| Args: | ||
| source: Can be: | ||
| - Path object pointing to a JSON file | ||
| - String containing a file path to a JSON file | ||
| - String containing raw JSON content | ||
| - None (returns None) | ||
|
|
||
| Returns: | ||
| Parsed JSON (dict, list, or other JSON-serializable type), or None if input is None | ||
|
|
||
| Raises: | ||
| ValueError: If source cannot be parsed as JSON or loaded from file | ||
| TypeError: If source is not a supported type | ||
| """ | ||
| if source is None: | ||
| return None | ||
|
|
||
| if isinstance(source, Path): | ||
| # It's a Path object, read from file | ||
| try: | ||
| with open(source, "r", encoding="utf-8") as f: | ||
| return json.load(f) | ||
| except FileNotFoundError: | ||
| raise ValueError(f"File not found: {source}") | ||
| except json.JSONDecodeError as e: | ||
| raise ValueError(f"Invalid JSON in file {source}: {e}") | ||
|
|
||
| elif isinstance(source, str): | ||
|
Contributor
There was a problem hiding this comment. maybe the I think this could avoid the multiple attempts to open it as a file |
||
| # It's a string - could be a file path or JSON content | ||
| stripped = source.strip() | ||
|
|
||
| # Check if it looks like JSON (starts with {, [, or is a quoted string) | ||
| if stripped and stripped[0] in '{["' or stripped in ("true", "false", "null"): | ||
| # Try as JSON first | ||
| try: | ||
| return json.loads(source) | ||
| except json.JSONDecodeError: | ||
| # If it fails, try as file path | ||
| try: | ||
| with open(source, "r", encoding="utf-8") as f: | ||
| return json.load(f) | ||
| except FileNotFoundError: | ||
| # Original JSON parse error is more relevant | ||
| raise ValueError( | ||
| f"Invalid JSON: {source[:100]}{'...' if len(source) > 100 else ''}" | ||
| ) | ||
| except json.JSONDecodeError as e: | ||
| raise ValueError(f"Invalid JSON in file {source}: {e}") | ||
| else: | ||
| # Doesn't look like JSON, try as file path first | ||
| try: | ||
| with open(source, "r", encoding="utf-8") as f: | ||
| return json.load(f) | ||
| except FileNotFoundError: | ||
| # Last attempt: maybe it's JSON without typical start chars | ||
| try: | ||
| return json.loads(source) | ||
| except json.JSONDecodeError: | ||
| raise ValueError( | ||
| f"'{source}' is neither a valid file path nor valid JSON" | ||
| ) | ||
| except json.JSONDecodeError as e: | ||
| raise ValueError(f"Invalid JSON in file {source}: {e}") | ||
| else: | ||
| raise TypeError( | ||
| f"source must be Path, str, or None, got {type(source).__name__}" | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could benefit from indicating some structure of the JSON, e.g. what fields it expects and which are optional.