don't create a jabs directory if the user selects a project directory that doesn't contain videos - #251
Merged
gbeane merged 4 commits intoDec 30, 2025
Conversation
… that doesn't contain videos
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents JABS from creating the "jabs" subdirectory when a user selects an invalid project directory that lacks video or pose files, helping avoid clutter from accidental directory selections.
- Added validation to check for video and pose files before creating the jabs directory
- Updated
create_directoriesmethod with an optionalvalidateparameter - Raises
ValueErrorwhen attempting to create directories in an invalid project location
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bergsalex
approved these changes
Dec 30, 2025
keithshep
approved these changes
Dec 30, 2025
gbeane
deleted the
avoid-creating-jabs-directory-when-user-selects-wrong-dir
branch
December 30, 2025 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the user selects the wrong directory, JABS always creates the "jabs" subdirectory. If the user tries to open a project without any videos or pose files, we assume they selected the wrong directory and abort