removing sklearn gradient booster, to be replaced with other options - #244
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the sklearn Gradient Boosting classifier option from JABS in preparation for adding new classifier implementations (KLAUS-310). The changes refactor the classifier type system from integer-based enums to string-based enums and consolidate classifier instantiation logic.
Key Changes:
- Removed Gradient Boosting classifier option entirely
- Changed
ClassifierTypefromIntEnumtostr, Enumwith string values - Refactored classifier instantiation to use a factory pattern with centralized mapping
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/jabs/types/classifier_types.py |
Changed enum from IntEnum to str Enum, removed GRADIENT_BOOSTING option |
src/jabs/scripts/classify.py |
Simplified help text by removing version specificity |
src/jabs/resources/docs/user_guide/user_guide.md |
Updated CLI documentation to remove gradient-boosting option |
src/jabs/project/export_training.py |
Changed classifier_type attribute to use string representation |
src/jabs/classifier/classifier.py |
Major refactoring: removed gradient boosting, added factory pattern, improved random seed handling |
src/jabs/classifier/__init__.py |
Removed unused HYPERPARAMETER_PATH constant and import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… instead of ClassifierType due to ClassifierType now inheriting from both str and Enum instead of IntEnum
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This is in preparation for upcoming work (KLAUS-310) to add some new classifier implementations to JABS
removes sklearn gradient booster, also does a little refactoring to make it easier to add some additional choices when we implement KLAUS-310