Repository navigation
Conversation
The editor shell opened with a 50/50 main/timeline split, so an empty or short timeline claimed half the screen while the preview was squeezed into the other half. DEFAULT_PANELS now derives the split from EDITOR_LAYOUT.timelineDefaultSize (28 for the default compact density) instead of carrying its own 50 — one source of truth, main and timeline still summing to 100. The store is persisted, so a version 2 migration handles existing users: layouts still sitting on the untouched v1 50/50 default move to the new split; anything the user resized themselves is left alone. The migration is exported and unit-tested. Also reconciles the editor.test.tsx scaffolding, which mocked the store at 50 while separately mocking timelineDefaultSize as 35 — the layout mock no longer overrides timeline sizes and the store mock matches the real default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
What
The editor opened with a 50/50 main/timeline split — an empty timeline took half the screen while the preview was squeezed into the other half.
How
DEFAULT_PANELSnow derives the split fromEDITOR_LAYOUT.timelineDefaultSizeinstead of carrying its own50. That preset already existed ineditor-layout.ts(28 for the default compact density, 30 for default) but nothing consumed it for the panel — the store had a second, disagreeing source of truth. Result: timeline 28, mainContent 72, still summing to 100. 28 sits in the issue's suggested 28–35 range and is the value the density preset always intended.version: 2with a migration — layouts still sitting on the untouched v1 50/50 default move to the new split; anything the user resized themselves is preserved exactly. (A user who manually dragged to exactly 50/50 is indistinguishable from never-touched and gets the new default — accepted trade-off.) The migration is an exported pure function with 5 unit tests.minSize={15}/maxSize={70}on the panel untouched, per the acceptance criteria.editor.test.tsxscaffolding the issue flagged: it mocked the store attimeline: 50while separately mockingtimelineDefaultSize: 35. The layout mock no longer overrides timeline sizes and the store mock matches the real default.Verification (headless Chromium, dev server)
Drag test: handle dragged to the extremes clamps at 70 (top) and ~15 (bottom) — full range intact.
lint✅ ·check:boundaries✅ ·test:run212/212 files, 1266/1266 tests greenNote
resetPanels()exists on the store but has no UI entry point (the issue asked to confirm) — nothing currently lets a user return to the default layout except clearing storage. Happy to file a follow-up issue for a "Reset layout" menu item if wanted.