Skip to content

Change some warnings to errors #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DilumAluthge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change some warnings to errors #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backporter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ function find_pr_associated_with_commit(hash::AbstractString, config::BackportCo
pr = parse(Int, basename(item["pull_request"]["url"]))
return pr
catch e
@warn "Failed to find PR for commit $hash: $e"
error("Failed to find PR for commit $hash: $e")
return nothing
end
end
Expand Down Expand Up @@ -517,7 +517,7 @@ function collect_label_prs(config::BackportConfig, auth::GitHubAuthenticator)
try
GitHub.pull_request(config.repo, pr_number; auth=auth_ref)
catch e
@warn "Failed to fetch PR #$pr_number: $e"
error("Failed to fetch PR #$pr_number: $e")
nothing
end
end
Expand Down Expand Up @@ -968,7 +968,7 @@ function apply_audit_changes(result::AuditResult, config::LabelAuditConfig)
remove_backport_label(config, pr_num)
println(" Removed label from #$pr_num")
catch e
println(" Error processing #$pr_num: $e")
error("Error processing #$pr_num: $e")
end
end

Expand Down