Add guild_media channel type (16)#727
Open
Sim-hu wants to merge 1 commit into
Open
Conversation
Add the GUILD_MEDIA channel type introduced by Discord for media-heavy content channels. This includes the constant, typespec, and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GUILD_MEDIA(type 16) toNostrum.Constants.ChannelTypeguild_media_channeltypespec toNostrum.Struct.ChannelMotivation
Discord introduced the
GUILD_MEDIAchannel type (16) for media-heavy content channels. It behaves similarly to forum channels but is optimized for visual media. nostrum currently defines types up toguild_forum(15) but is missing this type, which means media channels received from the gateway will have an unrecognized type value.Reference: https://discord.com/developers/docs/resources/channel#channel-object-channel-types
Changes
lib/nostrum/constants.ex— addguild_media/0returning16lib/nostrum/struct/channel.ex— add typespec, documentation table entry, and include in union typetTesting
mix compilepassesmix test— 212 tests, 0 failures