fix: use struct type in ApiError typespec#726
Merged
Conversation
The @type t for ApiError was defined as a plain map (%{...}) instead of a struct (%__MODULE__{...}). Since defexception creates a struct, the typespec should reflect that for accurate Dialyzer analysis. Closes Kraigie#725
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@type tforApiErrorwas defined as a plain map (%{...}) instead of a struct (%__MODULE__{...}). Sincedefexceptioncreates a struct, the typespec should reflect that for accurate Dialyzer analysis.This is consistent with how all other struct types in the codebase define their
@type t(e.g.,Nostrum.Struct.Emoji,Nostrum.Struct.Guild.Role).Closes #725