Advanced guide to managing your own application commands#668
Open
Th3-M4jor wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
A guide that's more or less based on what I do in my bot is ready. When reviewing be as nit-picky as you want to be with this, if this might replace Nosedrum I want it to be as good as we can make it be. Also, please squash merge the PR when/if its ready to merge |
Collaborator
|
I'm a bit confused why people should implement their own manager in the first place - doesn't this reproduce what nosedrum does? https://github.com/jchristgit/nosedrum/blob/master/lib/nosedrum/storage/dispatcher.ex#L1 |
Collaborator
|
If you don't mind I would like to park this one for a while.
I feel like storing the commands in a database is a bit too complicated for what we need. And I feel like the remaining behaviors should really be covered by nostrum itself with some simple application command behaviour.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guide for how you might manage your own Application Commands.
I chose to go with Ecto/EctoSQL in this example because that's more likely to be something readers are already to be familiar with as opposed to
:mnesiaor:dets.And if they want to instead use either, its not too tough to switch to it on their own.