Skip to content

Small cleanup - #673

Open
AbdullinAM wants to merge 4 commits into
mainfrom
abdullin/psi-utils-refactoring
Open

Small cleanup#673
AbdullinAM wants to merge 4 commits into
mainfrom
abdullin/psi-utils-refactoring

Conversation

@AbdullinAM

@AbdullinAM AbdullinAM commented Aug 14, 2026

Copy link
Copy Markdown
Member

Some small cleanups that are not entirely connected with each other rather that just being general refactorings and simplifications done while analyzing the code

  • Extract more utility methods from KIAV to PsuUtils
  • Simplify some of the TypeFormatter methods
  • delegate TypeFormatter::formatFunctionType.parameterList formatting to dedicated method
  • Use formatCommaSeparatedList in more cases where it can be used as a drop-in replacement. Other cases (e.g. visitFunctionLikeExpression) require more structural changes
  • Extract a separate formatInitializerExpression method for formatting everything that comes after =

@AbdullinAM
AbdullinAM requested a review from qwwdfsad August 14, 2026 15:51

@hick209 hick209 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, assuming this is just house ordering, which is what it looked like to me, but since it's a big change I know I might have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants