Repository navigation
fix(compiler-plugin): fix K2 story discovery and update test harness for Kotlin 2.3 - #116
Merged
Merged
Conversation
…for Kotlin 2.3 - Update kotlinCompileTesting to 0.12.1 in libs.versions.toml to support CompilerPluginRegistrar.pluginId in Kotlin 2.3+. - Use safe cast for FirMetadataSource in AddCodeSnippetToStoriesLowering to prevent ClassCastException. - Match story property delegate by factory type directly instead of relying on IrDeclarationOrigin.PROPERTY_DELEGATE, which is not consistently present in K2.
JSMonk
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IrDeclarationOrigin.PROPERTY_DELEGATE. As a result,isStoryreturnedfalse, and the compiler plugin discovered 0 stories.file.metadata as FirMetadataSourcecaused aClassCastExceptionwhen processing files where metadata is not represented asFirMetadataSource../gradlew :modules:compiler-plugin:testfailed withAbstractMethodErrorinMainComponentRegistrarbecausekotlinCompileTesting0.11.0 does not implementCompilerPluginRegistrar.getPluginId(), introduced in Kotlin 2.3.0.Solution
backingField?.type == factoryTypedirectly inMentionAllStoriesGettersInsideMainFunctionLowering.file.metadata as FirMetadataSourceto a safe castas?.kotlinCompileTestingfrom0.11.0to0.12.1ingradle/libs.versions.toml.Verification
./gradlew :modules:compiler-plugin:test(3/3 tests pass)./gradlew spotlessCheck(passes)./gradlew :examples:compileStoriesKotlinDesktop(builds successfully)./gradlew :examples:compileStoriesKotlinWasmJs(builds successfully)Visual Verification (Desktop & Wasm)
Desktop (
./gradlew :examples:desktopStoriesRun)Web / Wasm (
./gradlew :examples:wasmJsBrowserStoriesDevelopmentRun)