Add resetting FSM state to fix premature load_game -> game_start transition - #17
Merged
Conversation
…ove redundant frame clone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resettingstate betweenpokemon_summaryandload_gameto correctly model the soft reset blackoutresettingdetects dark top screen (V<50, ≥30% pixels) viacolor_histogramload_gamenow detects white bottom screen (save file) instead ofintensity_event, preventing premature transition on screen appearanceIntensityEventDetectordrop threshold lowered 0.40 → 0.30 for improved sensitivityXYStarterFennekinLiveintegration test with full frame boundary assertions verified against live camera footageTest plan
ctest --preset ninja-release -R XYStarterFennekin— both replay and live tests pass