Skip to content

Refactor Logger to use PIMPL and add SetLevel - #25

Merged
Konstantysz merged 4 commits into
mainfrom
feature/logger-pimpl-set-level
Feb 23, 2026
Merged

Refactor Logger to use PIMPL and add SetLevel#25
Konstantysz merged 4 commits into
mainfrom
feature/logger-pimpl-set-level

Conversation

@Konstantysz

Copy link
Copy Markdown
Owner

Description

This PR refactors the Kappa::Logger to support setting log levels while completely hiding spdlog implementation details from the public API.

Key Changes:

  • Hiding Implementation (PIMPL Pattern): Moved spdlog includes and the spdlog::logger member into src/Logger.cpp.
  • Custom LogLevel Enum: Introduced Kappa::LogLevel to replace spdlog enums in the API.
  • Added SetLevel: Support for dynamic log level adjustment.
  • Unit Tests: Added ests/TestLogger.cpp to verify level switching and formatting.

Verified with
inja-debug preset and all tests passed.

@github-actions

github-actions Bot commented Feb 23, 2026

Copy link
Copy Markdown

📊 Test Coverage Report

Coverage Statistics

Metric Coverage
Lines 61.68%
Functions 58.76%

@Konstantysz
Konstantysz merged commit 39a0789 into main Feb 23, 2026
12 checks passed
@Konstantysz
Konstantysz deleted the feature/logger-pimpl-set-level branch February 23, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant