fix(test): improve cloud sync tests to handle asynchronous loading and increase timeout - #10440
Merged
Conversation
…clicking workspace row
…g max failures limit
… for improved CI reliability
…ng logic and removing redundant comments
…sharding and disabling fail-fast
bobqiu-kong
enabled auto-merge (squash)
August 26, 2026 04:09
cwangsmv
reviewed
Aug 26, 2026
cwangsmv
reviewed
Aug 26, 2026
…justing retry logic
… and updating matrix configuration
… and adjusting timeouts
…ting matrix configuration
cwangsmv
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an intermittent CI failure in the Cloud Sync smoke test suite, seen error
The test itself (
Discard, branch and commit actionsincloud-sync.test.ts:26) is unchanged inbehavior — this is purely a stability fix for the wait strategy around one step.
Root cause
After
fetchUnsyncedWorkspace('My Collection R1')selects the workspace, the sidebar populates itsrequest tree (including the
New Requestrow) through a separate async chain — navigation/expandresolution →
getWorkspaceChildrenIPC → React Query enabling → render — with no visible loadingindicator.
fetchUnsyncedWorkspaceonly waits for the initial pull/fetch spinner to clear and for theworkspace row to become selected; it does not wait for that second chain to finish.
The very next line,
clickRequestOrFolder('New Request'), was relying on Playwright's default30000ms action timeout (hardcoded per-call, not affected by the 60s test-level timeout in
playwright.config.ts) to absorb that entire chain. Under normal load this finishes well under 30s,but under CI resource contention (6 parallel shards sharing one runner's CPU/disk) the chain
occasionally ran long enough to blow through the 30s budget, causing a flaky, hard-to-diagnose click
timeout.
Confirmed this is not a regression from any recent feature work — the PR the failure was observed on
(#10439) only bumps package versions and touches no
sync/sidebar code.
Changes
packages/insomnia-smoke-test/tests/smoke/cloud-sync.test.ts— added an explicitrequestRow('New Request').waitFor({ state: 'visible', timeout: 60_000 })betweenfetchUnsyncedWorkspace(...)andclickRequestOrFolder('New Request'), so the test waits on theactual missing signal (the row's own load) with dedicated headroom, instead of silently depending on
the click's default 30s timeout to cover unrelated async work.
Testing
npx eslint packages/insomnia-smoke-test/tests/smoke/cloud-sync.test.ts— clean.acceptance bar before reverting the workflow file and merging.