fix: fix sidebar drop indicator and actual landing spot - #10435
Open
Ali-Sab wants to merge 1 commit into
Open
Conversation
Ali-Sab
force-pushed
the
fix/folder-item-reorder
branch
from
August 21, 2026 21:47
0f68691 to
7c36869
Compare
Ali-Sab
force-pushed
the
fix/folder-item-reorder
branch
from
August 24, 2026 14:54
7c36869 to
96e33f6
Compare
Ali-Sab
force-pushed
the
fix/folder-item-reorder
branch
from
August 24, 2026 14:55
96e33f6 to
ba280fc
Compare
cwangsmv
self-requested a review
August 25, 2026 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes INS-2887, buggy drag and drop in sidebar. This PR will change the way the drag and drop works by dropping react-aria for a custom implementation that is well suited for our hierarchy and structure.
It adds deeper indicators that show the user exactly and precisely what happens on reorder, where the new item will go, in, around, above, below, another item or folder. It also adds an x-region, dropping an item on the left side of a folder will drop it under the folder, not inside it, dropping an item at the middle or the right of the folder's name will drop the item into the folder, the indicator will show this behaviour by including the folder's name on the drag/hover, so that users know exactly where the item will go before dropping it.
Screen.Recording.2026-08-21.at.5.49.36.PM.mov