Refactor/vcs - #10427
Open
xiaodemen wants to merge 1 commit into
Open
Conversation
xiaodemen
force-pushed
the
refactor/vcs
branch
2 times, most recently
from
August 21, 2026 07:05
f5bfa67 to
c8e5fd9
Compare
xiaodemen
marked this pull request as ready for review
August 21, 2026 07:05
xiaodemen
force-pushed
the
refactor/vcs
branch
from
August 21, 2026 07:26
c8e5fd9 to
055b9ae
Compare
ZxBing0066
previously approved these changes
Aug 21, 2026
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/Kong/insomnia.git", | ||
| "directory": "packages/insomnia-data" |
| @@ -166,7 +166,6 @@ | |||
| "zod": "^3.25.75" | |||
| }, | |||
| "devDependencies": { | |||
Member
There was a problem hiding this comment.
Should we also clean node-forge?
| @@ -0,0 +1,191 @@ | |||
| let v4Counter = 0; | |||
|
|
|||
| export const v4UUIDs = [ | |||
Member
There was a problem hiding this comment.
You can directly import it from insomnia-data instead of creating a duplicate one. We can find a way to make it shareable between packages in the future.
import { v4Mock } from '../insomnia-data/__mocks__/uuid';| @@ -1,4 +1,4 @@ | |||
| import type { BaseModel } from 'insomnia-data'; | |||
| import type { BaseModel } from './models/base-types'; | |||
Member
There was a problem hiding this comment.
Do you think this file should also in insomnia-vcs instead of insomnia-data?
yaoweiprc
previously approved these changes
Aug 25, 2026
refactor(vcs): move vcs to insomnia-vcs fix: fix comments
xiaodemen
force-pushed
the
refactor/vcs
branch
from
August 25, 2026 09:19
1898e22 to
1383059
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const rawKey = typeof jwkOrKey === 'string' ? jwkOrKey : _b64UrlToHex(jwkOrKey.k || ''); | ||
| const key = forge.util.hexToBytes(rawKey); | ||
| const iv = forge.random.getBytesSync(12); | ||
| const cipher = forge.cipher.createCipher('AES-GCM', key); |
| const rawKey = typeof jwkOrKey === 'string' ? jwkOrKey : _b64UrlToHex(jwkOrKey.k || ''); | ||
| const key = forge.util.hexToBytes(rawKey); | ||
| const iv = forge.random.getBytesSync(12); | ||
| const cipher = forge.cipher.createCipher('AES-GCM', key); |
| // ~~~~~~~~~~~~~~~~~~~~ // | ||
| // Decrypt with AES-GCM // | ||
| // ~~~~~~~~~~~~~~~~~~~~ // | ||
| const decipher = forge.cipher.createDecipher('AES-GCM', key); |
| // ~~~~~~~~~~~~~~~~~~~~ // | ||
| // Decrypt with AES-GCM // | ||
| // ~~~~~~~~~~~~~~~~~~~~ // | ||
| const decipher = forge.cipher.createDecipher('AES-GCM', key); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.