Repository navigation
Bridge 1b: the ASR worker wait in the console, quiet in notifications - #146
Merged
Merged
Conversation
…elf-resuming parks - asr_worker_waiting (no ASR worker connected and the Bridge's fallback is wait, or no ASR of its own) joins transientParks: it resumes by itself, and a sleeping laptop worker would otherwise park, and announce, each book that reaches its transcription. - The console words it (KNOWN_PARKS, bridge.park.asr_worker_waiting), and library_not_writable, which had no sentence; the Workers card's empty state points at the Bridge's Workers tab instead of a later version. - es/fr/it/pt: the Bridge's gender and the job's word as elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server side of Bridge Phase 1b (KodeStar/audiosilo-bridge#3): the Bridge gained native ASR workers. The worker protocol is Bridge-internal; what reaches the server is the heartbeat's
workers(already accepted since Phase 0) and one new park code.asr_worker_waiting(no ASR worker is connected and the Bridge'sasr.worker_fallbackiswait, or it has no ASR of its own) joinstransientParks: it resumes by itself when a worker connects, and a sleeping laptop worker would otherwise announce each book that reaches its transcription. Test: the notification sequence insidecars_test.go.KNOWN_PARKS,bridge.park.asr_worker_waitingin 6 locales), and alsolibrary_not_writable, which had no sentence. The Workers card's empty state points at the Bridge's Workers tab instead of "a later version".Real stack: with the fallback at
waitand the worker stopped, the job parkedasr_worker_waitingand a configured webhook received nothing; it went back to running when the worker reconnected.Quality passes:
/simplify(paired reviewers for this small, data-only diff: clean; the hand-kept park lists in console and player are a known pattern, a hint fallback for unknown codes is a follow-up) then/code-review xhigh --fix(8 findings: 5 fixed, the notification one decided as above; left: a pre-1b Bridge's empty state, a direct#workerslink).Gates:
scripts/build-admin.sh(825 tests),go build/vet,golangci-lint run(0),go test -race ./...(a load flake ininternal/backuppassed on rerun).