Repository navigation
Match review: best match first, and Match by hand over the review - #143
Merged
Merged
Conversation
The review's lists page by score (descending, a tie in recorded order), the cursor still an item id, so 2,000 middling matches read best first rather than in the order the workers finished (#141). Match by hand opens the book page's match dialog over the review, which keeps its tab, picks and pages; a book matched there leaves the apply. The book page is a new tab away (#142).
The apply never writes over a match run's book that has an ASIN or ISBN now (matched by hand from the review, on its book page, by another admin, or a rescan found one): planFor gives it no changes, the review marks it matched_since and an apply skips it with that detail. The review's own hand-match state goes; the match dialog loads its book while open and says in place when it can't; one row is patched in place instead of every page asked again; the cursor is a row-value comparison.
A match whose cover a stop cut short stays to apply (cover_pending), so its own ASIN doesn't read as matched since and the next apply takes the cover; the review marks a row matched since only when the server would (a match run's pending book that has an identifier now), else asks for that tab again; an applied row is never left out twice; a hand match refreshes the Health issues.
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141, closes #142.
What changes
GET /admin/match-runs/{id}/itemspages by score (descending, ties in recorded order). The cursor is still an item id: the next page reads on from that item's score, so a review paged 50 at a time sees the whole outcome in one order. No wire change.matched_sincein the review with no changes, and an apply skips it with detailmatched_since, under any scope (before, Use community values would write the run's match over it).cover_pending), so the next apply takes it.MatchDialogloads its own book while open and shows a load error in place with a retry.Verification
Docs: KodeStar/audiosilo-docs (docs/match-review-sort).