Repository navigation
Bridge 1d: generated chapters caption, chapter detection stage and park - #114
Merged
Merged
Conversation
…ters_not_detected park
chapters_source widens to 'community' | 'generated' (ChaptersSource) on the item and
chapters envelopes. The book page's Chapters tab ends a detected list with a quiet
server-glyph caption, "Chapters found in the narration on this server". The Generate
status words the new engine stage chapter_detecting ("Finding the chapters in the
narration") and the park chapters_not_detected ("The Bridge couldn't find the chapters
in the narration."), in all 6 locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge Phase 1d (chapterless books), player side. Pairs with KodeStar/audiosilo-server#152 and KodeStar/audiosilo-bridge#5.
What
chapters_source: "generated"(additive, an open union): the book page's chapters show "Chapters found in the narration on this server"; an unknown future value shows no caption.chapter_detectingand parkchapters_not_detected(6 locales), and holds Generate back while achapters.detectjob is open (409detect_opengets its own message).Tests and review: client, hooks, bridge-model and book-page tests. /simplify and /code-review max --fix applied (including the gap sweep). Gate green: tsc, lint, prettier, jest (4924 tests).
Verified live (web player against a scratch server with a paired Bridge): the caption and 5 found chapters; seeking to Stave Three and Stave Five lands on their starts. Needs a device run: the caption on iOS/Android.