Improve 'duration' filter - #205
Open
iatanasov77 wants to merge 3 commits into
Open
Conversation
kbond
reviewed
Nov 8, 2023
kbond
left a comment
kbond
left a comment
Collaborator
There was a problem hiding this comment.
In general, I'm not sure about this. I wanted to keep the same logic as symfony/console, which is a very approximate duration. I admit at lower durations, the approximation can be way off though.
| * @source https://github.com/symfony/symfony/blob/ad72245261792c6b5d2db821fcbd141b11095215/src/Symfony/Component/Console/Helper/Helper.php#L97 | ||
| */ | ||
| public function formatDuration(float $seconds, string $locale = null): string | ||
| public function formatDuration(float $seconds, int $precision = 2, string $locale = null): string |
Collaborator
There was a problem hiding this comment.
What about
Suggested change
| public function formatDuration(float $seconds, int $precision = 2, string $locale = null): string | |
| public function formatDuration(float $seconds, string $locale = null, ?int $precision = null): string |
Adding the $precision before $locale is a BC break. Default to null to keep current behavior by default.
| return $this->translator->trans( | ||
| $format[1], | ||
| ['%count%' => floor($seconds / $format[2])], | ||
| ['%count%' => number_format($seconds / $format[2], $precision)], |
Collaborator
There was a problem hiding this comment.
Suggested change
| ['%count%' => number_format($seconds / $format[2], $precision)], | |
| ['%count%' => null === $precision ? floor($seconds / $format[2]) : number_format($seconds / $format[2], $precision)], |
To keep the current behaviour.
Author
There was a problem hiding this comment.
My previous logic was wrong :( I remove the precision parameter and add a private method that format the seconds into float number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.