Repository navigation
feat(presets): put PDF to XLSX on the PDF donut - #1401
Merged
Merged
Conversation
PDF to XLSX works but sat on no PDF donut, so people couldn't find it (#1343, #1187). A new library has it on the PDF front after DOCX: the new-install back face is already at the eight-slice limit, and XLSX is a conversion. Settings schema 80 gives it to a PDF face that is still exactly as Filee made it: the front of a library made since the slot cleanup, or the back (after Compress PDF) of an older one, whose front is full. A face the user changed is left alone. Refs #1343, #1187 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the schema 80 step that gave existing PDF donuts the XLSX slot, and the schema bump: new defaults are for new installs (#806). Existing users add XLSX from Settings > Donut toolbar. The test contracts for older libraries are back as on main. Refs #1343, #1187 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What users notice
PDF → XLSX (tables to a spreadsheet) has shipped since 2.1.0, but it wasn't on the PDF donut, so people dropping a PDF didn't find it (#1343, #1187). After a new install or Reset to default, XLSX sits on the PDF donut's front, right after DOCX:
PNG, JPG, DOCX, XLSX, PPTX (slides), TXT, HWPX, HWP
Existing libraries are not changed (#806: new defaults are for new installs). Existing users add it once from Settings → Donut toolbar → PDF, dragging the XLSX chip onto the donut, as described in #1343 and #1187.
Why the front, not the back
The new-install PDF back face is already at #806's limit of eight slices (
A_new_library_has_the_new_layout_and_at_most_eight_a_face), while the front had a free eighth slot. #806's "front is conversions, back is edits" rule also puts a conversion like XLSX on the front.What changed
src/Filee.Core/Presets/BuiltInData.cs:to-xlsxafterto-docxon the new-install PDF front (CreateProfiles).ProfilesSchema58and the migrations are untouched, so there's no schema bump.Tests
tests/Filee.Core.Tests/PdfXlsxSlotTests.cs: a new library has XLSX on the PDF front after DOCX, and the schema 58 PDF donut (what existing libraries keep) still doesn't have it.BackFaceTests.SlotTableExpectedFacesPDF front, and the 1.0.1/1.1.0 round trip inBackFaceTests(it starts from a new library), now include XLSX.dotnet test tests/Filee.Core.Tests: 1231 passed, 8 skipped, 0 failed.dotnet test tests/Filee.App.Testsfiltered to DefaultPlacementTests, DonutFlipTests, ToolbarEditorTests and FolderIso632Tests: 72 passed, 3 skipped. I didn't run the whole App suite here; CI covers it.dotnet format --verify-no-changesis clean on Filee.Core and Filee.Core.Tests.Refs #1343, #1187
🤖 Generated with Claude Code