feat(skills): extend github with AC-walk and close-with-evidence patterns 🎓#134
Draft
Klazomenai wants to merge 1 commit into
Draft
feat(skills): extend github with AC-walk and close-with-evidence patterns 🎓#134Klazomenai wants to merge 1 commit into
Klazomenai wants to merge 1 commit into
Conversation
…erns 🎓 Adds "## Issue Acceptance-Criteria Verification at Close" section covering the operator-strict workflow for closing issues against `Refs #N` PRs: - Five-step walk-and-decide process (list / classify / verify / decide / comment) - Three evidence types: code-state-verifiable, CI-state, operational-test (incl. deferral-by-invariant for forward-looking AC) - Verification table format (one row per AC + evidence column + commit SHA) - 100%-or-don't-close rule with open-is-the-load-bearing-signal rationale - Auto-close keyword discipline (Closes/Fixes/Resolves never appear in commit/PR text; closure is explicit via `gh issue close`) - Worked example showing a partial-completion progress table Anti-Patterns section gains: - Closing an issue without walking each AC against evidence - Using auto-close keywords even when authorised to close Section slots between `PR Review Replies` and `Deployment Sign-Off Conventions` so the file flows: PR-review walk → PR-reply mechanics → Issue-close walk → Deployment sign-off. Pattern codifies discipline previously living in operator-internal notes (memory/feedback_refs_issue_review.md). Refs #115 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
claude/skills/github/SKILL.mdwith the operator-strict workflow for closingRefs #Nissues post-merge:gh issue close, never implicit via merge-timeCloses #N)Section slots between
PR Review RepliesandDeployment Sign-Off Conventionsso the file flows: PR-review walk → PR-reply mechanics → Issue-close walk → Deployment sign-off.Codifies discipline previously living only in operator-internal notes.
Test plan
make install-claudesucceeds and propagates new section to~/.claude/skills/github/SKILL.mdgrep -n "## Issue Acceptance-Criteria Verification at Close" claude/skills/github/SKILL.md→ present at line 91grep -n "### Worked example" claude/skills/github/SKILL.md→ present at line 131Closing an issue without walking each AC,Using ... auto-close keywords even when authorised)#115with verification table citing this commit SHARefs #115