Skip to content

Initial import + refine generated PowerShell templates for HARD-001, …#3

Merged
Kjean13 merged 1 commit into
mainfrom
fix-ps-templates
Mar 17, 2026
Merged

Initial import + refine generated PowerShell templates for HARD-001, …#3
Kjean13 merged 1 commit into
mainfrom
fix-ps-templates

Conversation

@Kjean13

@Kjean13 Kjean13 commented Mar 17, 2026

Copy link
Copy Markdown
Owner

…HARD-010 and HARD-012

Summary

Describe the change clearly and factually.

Scope

  • CLI
  • Canonical conversion / ingestion
  • Detection rulepack
  • Correlation / timeline / reconstruction
  • Scoring / hardening
  • API / Guardian UI
  • Flet UI
  • Documentation
  • Tests / datasets

Validation

List the commands, tests, or datasets used to validate the change.

pytest -q

Notes

State any limitation, compatibility concern, or follow-up work.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e730f9c82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +36 to +39
param(
[string]$SearchBase = "",
[string]$CsvPath = ""
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move param block ahead of executable header statements

This new param(...) block is injected after SCRIPT_HEADER, which already emits executable statements (Set-StrictMode and $ErrorActionPreference) before template content, so generated scripts for HARD-001/HARD-010/HARD-012 place param too late in the file. In PowerShell, script-level param must appear before executable statements (aside from comments/#Requires), so these generated remediation scripts will fail to parse instead of running.

Useful? React with 👍 / 👎.

@Kjean13 Kjean13 merged commit a8cd479 into main Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant