Skip to content
This repository was archived by the owner on May 19, 2026. It is now read-only.

COMP: Update examples to the new build system to avoid warnings - #142

Merged
dzenanz merged 2 commits into
KitwareMedical:mainfrom
dzenanz:itk6
Mar 12, 2026
Merged

COMP: Update examples to the new build system to avoid warnings#142
dzenanz merged 2 commits into
KitwareMedical:mainfrom
dzenanz:itk6

Conversation

@dzenanz

@dzenanz dzenanz commented Mar 11, 2026

Copy link
Copy Markdown
Member

Warning that was triggered:

CMake Warning (dev) at CMake/UseITK.cmake:28 (message):
  CMake/UseITK.cmake is deprecated.

  Please update CMakeLists.txt to use `find_package(ITK)` and link to
  "${ITK_INTERFACE_LIBRARIES}".

Call Stack (most recent call first):
  Modules/Remote/MorphologicalContourInterpolation/examples/CMakeLists.txt:12 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

@dzenanz
dzenanz requested a review from blowekamp March 11, 2026 20:49

@blowekamp blowekamp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blowekamp

Copy link
Copy Markdown

Are you building this module as part of the ITK build or as an independent build against an already build ITK?

I am not seeing much usage of itk_module_examples. Are you aware of any other use cases of it in a remote module?

Using find_package under the Modular Macro infrastructure seems... unique or unusual. I am actually not sure how dependencies of this itk_module_example are expressed.

https://github.com/KitwareMedical/ITKContourInterpolation/blob/main/CMakeLists.txt#L40

@dzenanz

dzenanz commented Mar 12, 2026

Copy link
Copy Markdown
Member Author

Yes, I was trying to build it as part of ITK build. I will try to restore the old detection of that via ITK_SOURCE_DIR.

Warning that was triggered:

CMake Warning (dev) at CMake/UseITK.cmake:28 (message):
  CMake/UseITK.cmake is deprecated.

  Please update CMakeLists.txt to use `find_package(ITK)` and link to
  "${ITK_INTERFACE_LIBRARIES}".

Call Stack (most recent call first):
  Modules/Remote/MorphologicalContourInterpolation/examples/CMakeLists.txt:12 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.
@dzenanz

dzenanz commented Mar 12, 2026

Copy link
Copy Markdown
Member Author

The force-push fixes it.

@dzenanz
dzenanz marked this pull request as ready for review March 12, 2026 13:33
@dzenanz
dzenanz merged commit 75c256e into KitwareMedical:main Mar 12, 2026
23 checks passed
@dzenanz
dzenanz deleted the itk6 branch March 12, 2026 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants