Skip to content

new MBD API - #946

Merged
mlfarrell merged 22 commits into
mainfrom
mike/mbd-api-updates
Sep 22, 2025
Merged

new MBD API#946
mlfarrell merged 22 commits into
mainfrom
mike/mbd-api-updates

Conversation

@mlfarrell

@mlfarrell mlfarrell commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

https://www.gdandtbasics.com/asme-y14-5-gdt-standard/

to be paired with https://github.com/KittyCAD/engine/pull/3787

Can someone else who isn't me please fix the lints. i've hit my limit with rust coding for the week.

@mlfarrell mlfarrell changed the title Mike/mbd api updates new MBD API Sep 16, 2025
@codecov

codecov Bot commented Sep 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@caecee0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage        ?   26.19%           
=======================================
  Files           ?       35           
  Lines           ?     1714           
  Branches        ?        0           
=======================================
  Hits            ?      449           
  Misses          ?     1265           
  Partials        ?        0           
Flag Coverage Δ
unittests 26.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlfarrell
mlfarrell marked this pull request as ready for review September 17, 2025 22:15
@mlfarrell

Copy link
Copy Markdown
Contributor Author

Can someone else who isn't me please fix the lints. i've hit my limit with rust coding for the week.

@mlfarrell
mlfarrell requested a review from jessfraz September 17, 2025 22:16
@mlfarrell

Copy link
Copy Markdown
Contributor Author

looks like #[allow(clippy::large_enum_variant)] may be enough to get us past clippy/lint here

Comment thread modeling-cmds/src/shared.rs Outdated
Comment thread modeling-cmds/src/shared.rs Outdated
Comment thread modeling-cmds/src/shared.rs Outdated
Comment thread modeling-cmds/src/shared.rs
Comment thread modeling-cmds/src/shared.rs
@mlfarrell
mlfarrell requested a review from alteous September 19, 2025 19:48
@mlfarrell

Copy link
Copy Markdown
Contributor Author

as you guys know, i've been going back and forth between this repo and the engine repo all week. so i'd really like to get this approved without any more minor changes unless there is a major need. This churn on the rust side has eaten up my entire week which I had originally set aside for some R&D tasks for engine.

@mlfarrell
mlfarrell merged commit f31a23e into main Sep 22, 2025
13 checks passed
@mlfarrell
mlfarrell deleted the mike/mbd-api-updates branch September 22, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants