Make KCL execution optional via feature flag - #1322
Merged
Merged
Conversation
Use `--features exec-kcl` to enable this. Helpful to avoid unnecessary dependency on kcl-api and kcl-error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=======================================
Coverage ? 31.35%
=======================================
Files ? 36
Lines ? 1805
Branches ? 0
=======================================
Hits ? 566
Misses ? 1239
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lee-at-zoo-corp
approved these changes
Aug 14, 2026
jtran
approved these changes
Aug 14, 2026
adamchalmers
added a commit
that referenced
this pull request
Aug 14, 2026
# Changed - Make KCL execution optional via feature flag `exec-kcl` (#1322)
adamchalmers
added a commit
to KittyCAD/modeling-app
that referenced
this pull request
Aug 14, 2026
Pulls in this kcmc PR: KittyCAD/modeling-api#1322, which makes its kcl-error and kcl-api dependencies optional, so that if you're not going to execute KCL, you don't need them. And this repo doesn't need them. Makes the build-wasm job 2.5 minutes faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
--features exec-kclto enable this.Helpful to avoid unnecessary dependency on kcl-api and kcl-error. Those dependencies are large and add a lot of compile time. Also avoids compiling two copies of kcl-api in kcl-lib (one from the modeling-app/rust/kcl-api, and one from crates.io via kcmc here)