Skip to content

Tests: Fix testCreateFormWithInvalidCustomField #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n7studios merged 10 commits into from
Jul 7, 2026
Merged

Tests: Fix testCreateFormWithInvalidCustomField #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa01275
Tests: Update GitHub Actions for Node 20 deprecation
n7studios Jun 30, 2026
050426b
Tests: Remove `nanasess/setup-chromedriver@master`
n7studios Jul 3, 2026
ed528ce
Use Kit WordPress Libraries 2.1.7
n7studios Jul 3, 2026
cbad941
Tests: Fix `testCreateFormWithInvalidCustomField`
n7studios Jul 3, 2026
88e34d4
Merge remote-tracking branch 'origin/revert-144' into tests-remove-se…
n7studios Jul 3, 2026
abc968b
Merge remote-tracking branch 'origin/revert-144' into tests-update-ac…
n7studios Jul 3, 2026
3ef4251
Merge remote-tracking branch 'origin/revert-144' into use-wp-libs-2.1.7
n7studios Jul 3, 2026
2c3864d
Merge pull request #147 from Kit/tests-update-actions
n7studios Jul 7, 2026
0cec057
Merge pull request #148 from Kit/tests-remove-setup-chromedriver-action
n7studios Jul 7, 2026
043737f
Merge pull request #149 from Kit/use-wp-libs-2.1.7
n7studios Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
steps:
- name: Define Test Group Name
id: test-group
uses: mad9000/actions-find-and-replace-string@5
uses: mad9000/actions-find-and-replace-string@6
with:
source: ${{ matrix.test-groups }}
find: '/'
Expand Down Expand Up @@ -235,9 +235,6 @@ jobs:

- name: Start nginx
run: sudo systemctl start nginx.service

- name: Install chromedriver
uses: nanasess/setup-chromedriver@master

- name: Start chromedriver
run: |
Expand All @@ -262,22 +259,20 @@ jobs:

# Write any secrets, such as API keys, to the .env.testing file now.
- name: Define GitHub Secrets in .env.dist.testing
uses: DamianReeves/write-file-action@v1.3
with:
path: ${{ env.PLUGIN_DIR }}/.env.testing
contents: |
CONVERTKIT_API_KEY=${{ env.CONVERTKIT_API_KEY }}
CONVERTKIT_API_SECRET=${{ env.CONVERTKIT_API_SECRET }}
CONVERTKIT_API_KEY_NO_DATA=${{ env.CONVERTKIT_API_KEY_NO_DATA }}
CONVERTKIT_API_SECRET_NO_DATA=${{ env.CONVERTKIT_API_SECRET_NO_DATA }}
CONVERTKIT_OAUTH_ACCESS_TOKEN=${{ env.CONVERTKIT_OAUTH_ACCESS_TOKEN }}
CONVERTKIT_OAUTH_REFRESH_TOKEN=${{ env.CONVERTKIT_OAUTH_REFRESH_TOKEN }}
CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA=${{ env.CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA }}
CONVERTKIT_OAUTH_REFRESH_TOKEN_NO_DATA=${{ env.CONVERTKIT_OAUTH_REFRESH_TOKEN_NO_DATA }}
CONVERTKIT_OAUTH_CLIENT_ID=${{ env.CONVERTKIT_OAUTH_CLIENT_ID }}
CONVERTKIT_OAUTH_REDIRECT_URI=${{ env.CONVERTKIT_OAUTH_REDIRECT_URI }}
KIT_OAUTH_REDIRECT_URI=${{ env.KIT_OAUTH_REDIRECT_URI }}
write-mode: overwrite
run: |
cat > ${{ env.PLUGIN_DIR }}/.env.testing << 'ENVEOF'
CONVERTKIT_API_KEY=${{ env.CONVERTKIT_API_KEY }}
CONVERTKIT_API_SECRET=${{ env.CONVERTKIT_API_SECRET }}
CONVERTKIT_API_KEY_NO_DATA=${{ env.CONVERTKIT_API_KEY_NO_DATA }}
CONVERTKIT_API_SECRET_NO_DATA=${{ env.CONVERTKIT_API_SECRET_NO_DATA }}
CONVERTKIT_OAUTH_ACCESS_TOKEN=${{ env.CONVERTKIT_OAUTH_ACCESS_TOKEN }}
CONVERTKIT_OAUTH_REFRESH_TOKEN=${{ env.CONVERTKIT_OAUTH_REFRESH_TOKEN }}
CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA=${{ env.CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA }}
CONVERTKIT_OAUTH_REFRESH_TOKEN_NO_DATA=${{ env.CONVERTKIT_OAUTH_REFRESH_TOKEN_NO_DATA }}
CONVERTKIT_OAUTH_CLIENT_ID=${{ env.CONVERTKIT_OAUTH_CLIENT_ID }}
CONVERTKIT_OAUTH_REDIRECT_URI=${{ env.CONVERTKIT_OAUTH_REDIRECT_URI }}
KIT_OAUTH_REDIRECT_URI=${{ env.KIT_OAUTH_REDIRECT_URI }}
ENVEOF

# Installs wp-browser, Codeception, PHP CodeSniffer and anything else needed to run tests.
- name: Run Composer
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "project",
"license": "GPLv3",
"require": {
"convertkit/convertkit-wordpress-libraries": "2.1.6"
"convertkit/convertkit-wordpress-libraries": "2.1.7"
},
"require-dev": {
"php-webdriver/webdriver": "^1.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/EndToEnd/forms/FormBackwardCompatCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,8 @@ public function testCreateFormWithInvalidCustomField(EndToEndTester $I)
$I->waitForElementVisible('.wpforms-confirmation-scroll');
$I->seeInSource('Thanks for contacting us! We will be in touch with you shortly.');

// Check subscriber does not exist, as specifying an invalid custom field will result in an API error.
$I->apiCheckSubscriberDoesNotExist($I, $emailAddress);
// Check API to confirm subscriber was sent.
$I->apiCheckSubscriberExists($I, $emailAddress, $firstName);
}

/**
Expand Down