Skip to content

Uninstall: Update Token Revokation #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n7studios merged 2 commits into from
Jul 7, 2026
+13 −15
Merged

Uninstall: Update Token Revokation #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4966840
Uninstall: Update Token Revokation
n7studios Jul 4, 2026
4f3311c
Reinstate all tests
n7studios Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/EndToEnd/general/uninstall/UninstallCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ public function testPluginDeletionRevokesAndRemovesTokens(EndToEndTester $I)
// Delete the Plugin.
$I->deleteKitPlugin($I);

// Allow the uninstallation routine time to complete.
$I->wait(10);

@n7studios n7studios Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On occasion the test fails as it doesn't give WordPress enough time to complete uninstall.php. This bump of the wait seems to resolve.


// Confirm the credentials have been removed from the Plugin's settings.
$I->wait(3);
$settings = $I->grabOptionFromDatabase('_wp_convertkit_settings');
$I->assertEmpty($settings['access_token']);
$I->assertEmpty($settings['refresh_token']);
Expand Down
24 changes: 10 additions & 14 deletions uninstall.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,12 @@
'https://api.kit.com/v4/oauth/revoke',
array(
'headers' => array(
'Accept' => 'application/json',
'Content-Type' => 'application/json',
'Content-Type' => 'application/x-www-form-urlencoded',
),
'body' => wp_json_encode(
array(
'client_id' => 'HXZlOCj-K5r0ufuWCtyoyo3f688VmMAYSsKg1eGvw0Y',
'token' => $settings['access_token'],
)
'body' => array(
'client_id' => 'HXZlOCj-K5r0ufuWCtyoyo3f688VmMAYSsKg1eGvw0Y',
'token' => $settings['access_token'],
'token_type_hint' => 'access_token',
),
'timeout' => 5,
)
Expand All @@ -50,14 +48,12 @@
'https://api.kit.com/v4/oauth/revoke',
array(
'headers' => array(
'Accept' => 'application/json',
'Content-Type' => 'application/json',
'Content-Type' => 'application/x-www-form-urlencoded',
),
'body' => wp_json_encode(
array(
'client_id' => 'HXZlOCj-K5r0ufuWCtyoyo3f688VmMAYSsKg1eGvw0Y',
'token' => $settings['refresh_token'],
)
'body' => array(
'client_id' => 'HXZlOCj-K5r0ufuWCtyoyo3f688VmMAYSsKg1eGvw0Y',
'token' => $settings['refresh_token'],
'token_type_hint' => 'refresh_token',
),
'timeout' => 5,
)
Expand Down