Skip to content

Hiding all IPhreeqc symbols by default from our custom static library #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkingsbury merged 1 commit into from
Jun 16, 2026
Merged

Hiding all IPhreeqc symbols by default from our custom static library #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,19 @@ if(PYEQL_ENABLE_EXT)
include_directories(${IPHREEQC_INCLUDE_DIRS})
set(IPHREEQC_BUILD_DIR ${IPHREEQC_BASE}/build)
add_subdirectory(${IPHREEQC_DIR} ${IPHREEQC_BUILD_DIR})
set_target_properties(IPhreeqc PROPERTIES POSITION_INDEPENDENT_CODE ON)

# Hide IPhreeqc's symbols when it is statically linked into _phreeqc.so.
# Upstream IPhreeqc does not build with -fvisibility=hidden, so without
# this every Phreeqc/IPhreeqcLib symbol gets re-exported from _phreeqc.so.
# That collides with phreeqpython's own copy of IPhreeqc (a different
# build), causing segfault once both modules are loaded in the same Python
# process.
# See https://linuxvox.com/blog/c-fvisibility-hidden-fvisibility-inlines-hidden/
set_target_properties(IPhreeqc PROPERTIES
POSITION_INDEPENDENT_CODE ON
C_VISIBILITY_PRESET hidden
CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN ON)
# -------------------------------------------------------

# -------------------------------------------------------
Expand Down
Loading