Skip to content

Updated the LSODE integrator to be thread-safe #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yantosca wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Updated the LSODE integrator to be thread-safe #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a7e4b7
Updated the LSODE integrator to be thread-safe
yantosca Apr 23, 2026
2d8a66d
Fix remaining OpenMP data races in the thread-safe LSODE integrator
yantosca Jul 8, 2026
62e914b
RTD update: Removed warnings that LSODE is not thread-safe
yantosca Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased] - TBD
### Changed
- Updated `int/lsode.f90` to be OpenMP thread-safe
- Declared STEPMIN as threadprivate in the created `ROOT_Global.f90` and `ROOT_Global.F90` files

## [3.5.0] - 2026-07-09
### Added
Expand Down Expand Up @@ -39,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Removed
- Removed references to unneccessary `azure-cli` and `microsoft-prod` packages in `.github/workflows/run-ci-tests.yml`
- Removed warnings that the LSODE integraor is not thread-safe in ReadTheDocs

## [3.4.0] - 2026-04-29
### Added
Expand Down
9 changes: 0 additions & 9 deletions docs/source/reference/known-bugs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@ These `bug reports (on GitHub)
<https://github.com/KineticPreProcessor/KPP/issues?q=is%3Aissue%20state%3Aopen%20label%3Abug>`_
are currently unresolved. We hope to fix these in future releases.

LSODE integrator is not thread-safe
-----------------------------------

We have discovered that the current implementation of the LSODE
integrator is not thread-safe for `OpenMP parallelization
<https://www.openmp.org/>`_. When LSODE is called from within an
OpenMP parallel loop, the integration will fail because key internal
variables in LSODE will be overwritten by concurrent threads.

============================
Bugs that have been resolved
============================
Expand Down
Loading