Skip to content

vulkaninfo: Add VK_KHR_display support and related fixes#1229

Open
hapakj wants to merge 1 commit into
KhronosGroup:mainfrom
RasterGrid:rastergrid/khr-display-and-other-wsi-fixes
Open

vulkaninfo: Add VK_KHR_display support and related fixes#1229
hapakj wants to merge 1 commit into
KhronosGroup:mainfrom
RasterGrid:rastergrid/khr-display-and-other-wsi-fixes

Conversation

@hapakj

@hapakj hapakj commented Jun 17, 2026

Copy link
Copy Markdown

Add VK_KHR_display support and related fixes to vulkaninfo

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

@aqnuep aqnuep requested a review from charles-lunarg June 17, 2026 13:31
charles-lunarg
charles-lunarg approved these changes Jun 17, 2026
View reviewed changes

@charles-lunarg charles-lunarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of good defensive checks around surfaces that should of been there before, plus all the display improvements.

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

CI Vulkan-Tools build queued with queue ID 8195.

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

CI Vulkan-Tools build # 1987 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

CI Vulkan-Tools build # 1987 failed.

@charles-lunarg

charles-lunarg commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

windows failure

execute() call failed after 0.06 seconds (0.06 seconds): returncode=3221225477 (0xc0000005=STATUS_ACCESS_VIOLATION); execution log index: 14, working directory: C:\j\w4\64-bit\Release\vulkantest-results\vulkaninfo-mockicd

macOS failure


VkPhysicalDeviceSwapchainMaintenance1FeaturesEXT:
-------------------------------------------------
	swapchainMaintenance1 = t
ERROR: ----stack trace----------------------------------------------
Core file '/Users/lunarg/.jenkins/w4/64-bit/Release/vulkantest-results/vulkaninfo/core' (arm64) was loaded.
* thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x10)
  * frame #0: 0x00000001951c5820 libobjc.A.dylib`objc_msgSend + 32
    frame #1: 0x000000010686ab4c libMoltenVK.dylib`-[MVKBlockObserver stopObserving] + 36
    frame #2: 0x000000010686aa78 libMoltenVK.dylib`-[MVKBlockObserver dealloc] + 24
    frame #3: 0x0000000106891498 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 80
    frame #4: 0x00000001068914e4 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 12
    frame #5: 0x000000010688cda4 libMoltenVK.dylib`vkDestroySurfaceKHR + 84
    frame #6: 0x0000000100e50ae0 libvulkan.1.4.350.dylib`terminator_DestroySurfaceKHR + 212
    frame #7: 0x0000000100e50a00 libvulkan.1.4.350.dylib`vkDestroySurfaceKHR + 108
    frame #8: 0x0000000100c65750 vulkaninfo`AppInstance::~AppInstance() + 80
    frame #9: 0x0000000100c55de8 vulkaninfo`main + 3740
    frame #10: 0x0000000195249d54 dyld`start + 7184
ERROR: -------------------------------------------------------------
ERROR: FAIL during test after 28.40 seconds (28.40 seconds) with execute(/Users/lunarg/.jenkins/w4/64-bit/Release/Vulkan-Tools/build/install/bin/vulkaninfo) failed after 10.92 seconds (10.92 seconds) with returncode=-11 (-0xb=SIGSEGV)

@aqnuep

aqnuep commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thanks, @charles-lunarg we'll look into the failures.

Is the Windows failure that you see with a simple Mock ICD based setup? Because we did test this on Windows with multiple drivers.

@charles-lunarg

charles-lunarg commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Yes, this is the longer log (that I should of included from the get go)

INFO: exercising vulkaninfo with MockICD...
INFO: MockICD found at C:\j\w4\64-bit\Release\Vulkan-Tools\build\icd\Release\VkICD_mock_icd.json
INFO: set VK_ICD_FILENAMES=C:\j\w4\64-bit\Release\Vulkan-Tools\build\icd\Release\VkICD_mock_icd.json
INFO: cd C:\j\w4\64-bit\Release\vulkantest-results\vulkaninfo-mockicd
INFO: executing #14: C:\j\w4\64-bit\Release\Vulkan-Tools\build\install\bin\vulkaninfo.exe
ERROR: execute() call failed after 0.06 seconds (0.06 seconds): returncode=3221225477 (0xc0000005=STATUS_ACCESS_VIOLATION); execution log index: 14, working directory: C:\j\w4\64-bit\Release\vulkantest-results\vulkaninfo-mockicd
ERROR: FAIL during test after 4.86 seconds (4.86 seconds) with execute(C:\j\w4\64-bit\Release\Vulkan-Tools\build\install\bin\vulkaninfo.exe) failed after 0.06 seconds (0.06 seconds) with returncode=3221225477 (0xc0000005=STATUS_ACCESS_VIOLATION)

@hapakj hapakj force-pushed the rastergrid/khr-display-and-other-wsi-fixes branch from 20732c0 to 820cc67 Compare June 17, 2026 16:48
@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

CI Vulkan-Tools build queued with queue ID 8770.

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

CI Vulkan-Tools build # 1989 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jun 17, 2026

Copy link
Copy Markdown

CI Vulkan-Tools build # 1989 failed.

@charles-lunarg

charles-lunarg commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Now only the macOS CI failed:

Device Properties and Extensions:
=================================
GPU0:
VkPhysicalDeviceProperties:
---------------------------
	apiVersion        = 1.2.283 (4202779)
	driverVersion     = 0.2.2017 (10209)
	vendorID          = 0x106b
	deviceID          = 0x1a0103ef
	deviceType        = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU
	deviceName        = Apple M1
	pipelineCacheUUID = bf097edc-1a01-03ef-0000-000000000000

<output omitted>

VkPhysicalDeviceSubgroupSizeControlFeaturesEXT:
-----------------------------------------------
	subgroupSizeControl  = true
	computeFullSubgroups = true

VkPhysicalDeviceSwapchainMaintenance1FeaturesEXT:
-------------------------------------------------
	swapchainMaintenance1 = t
ERROR: ----stack trace----------------------------------------------
Core file '/Users/lunarg/.jenkins/w4/64-bit/Release/vulkantest-results/vulkaninfo/core' (arm64) was loaded.
* thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x4258)
  * frame #0: 0x0000000193d65820 libobjc.A.dylib`objc_msgSend + 32
    frame #1: 0x000000010a062b4c libMoltenVK.dylib`-[MVKBlockObserver stopObserving] + 36
    frame #2: 0x000000010a062a78 libMoltenVK.dylib`-[MVKBlockObserver dealloc] + 24
    frame #3: 0x000000010a089498 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 80
    frame #4: 0x000000010a0894e4 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 12
    frame #5: 0x000000010a084da4 libMoltenVK.dylib`vkDestroySurfaceKHR + 84
    frame #6: 0x00000001048a4ae0 libvulkan.1.4.350.dylib`terminator_DestroySurfaceKHR + 212
    frame #7: 0x00000001048a4a00 libvulkan.1.4.350.dylib`vkDestroySurfaceKHR + 108
    frame #8: 0x00000001046b9760 vulkaninfo`AppInstance::~AppInstance() + 80
    frame #9: 0x00000001046a9df8 vulkaninfo`main + 3740
    frame #10: 0x0000000193de9d54 dyld`start + 7184
ERROR: -------------------------------------------------------------
ERROR: FAIL during test after 24.07 seconds (24.07 seconds) with execute(/Users/lunarg/.jenkins/w4/64-bit/Release/Vulkan-Tools/build/install/bin/vulkaninfo) failed after 6.48 seconds (6.48 seconds) with returncode=-11 (-0xb=SIGSEGV)

@aqnuep

aqnuep commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

It seems like both were "driver" issues, not vulkaninfo, but we had to apply some workarounds:

Per above, MockICD was broken, the fix is already in this PR.

For the MacOS issue, apparently MoltenVK is buggy and will crash in vkDestroySurfaceKHR if the window is destroyed before the call (which is an obvious driver bug, but what can one do).

@hapakj will post a workaround to vulkaninfo.

@hapakj hapakj force-pushed the rastergrid/khr-display-and-other-wsi-fixes branch from 820cc67 to 57f71dc Compare June 18, 2026 10:43
@ci-tester-lunarg

ci-tester-lunarg commented Jun 18, 2026

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

ci-tester-lunarg commented Jun 18, 2026

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hapakj @ci-tester-lunarg @charles-lunarg @aqnuep