Fix instant-ngp submodule to a specific commit for compatibility with scripts/colmap2nerf.py - #17
Open
0mil wants to merge 1 commit into
Open
Fix instant-ngp submodule to a specific commit for compatibility with scripts/colmap2nerf.py#170mil wants to merge 1 commit into
0mil wants to merge 1 commit into
Conversation
…ity with scripts/colmap2nerf.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
instant-ngpsubmodule to a specific commit (9129d680bea305d457214c3e4ed45bca8ded6b86) that ensures compatibility with thescripts/colmap2nerf.pyscript.Context
During the use of
scripts/colmap2nerf.py, it was observed that the submodule was not compatible with the current version, leading to issues. After further investigation, it was determined that an earlier version oftransforms.jsonis needed to runprepare_data.py.Changes
instant-ngpsubmodule to commit9129d680bea305d457214c3e4ed45bca8ded6b86.Linked Issue
This PR addresses Issue #12.
Please review and let me know if any additional changes are needed.
Thank you!
Fixes #12