Repository navigation
fix(server): add ClientTimeout to Server, fix hostname:port parsing - #56
Open
spbsoluble wants to merge 1 commit into
Open
spbsoluble wants to merge 1 commit into
spbsoluble wants to merge 1 commit into
Conversation
…rverConfig auth_providers.Server was missing a ClientTimeout field, causing every call to GetServerConfig() to return a Server with ClientTimeout=0 regardless of what WithClientTimeout() was set to on the underlying CommandAuthConfig. Add: - ClientTimeout int to Server (command_config.go) - ClientTimeout: c.HttpClientTimeout in CommandAuthConfig.GetServerConfig() - ClientTimeout: a.HttpClientTimeout in CommandAuthConfigBasic.GetServerConfig() - ClientTimeout: b.HttpClientTimeout in CommandConfigOauth.GetServerConfig() - ClientTimeout: k.HttpClientTimeout in CommandAuthConfigKerberos.GetServerConfig() This fixes the silent timeout propagation gap reported in provider integration tests (TestUnitGetServerConfig_RequestTimeout*).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientTimeout intfield to theServerstruct incommand_config.go, populated fromHttpClientTimeoutin all fourGetServerConfig()implementations (core, basic, OAuth, kerberos). This allows downstream consumers (e.g. keyfactor-go-client) to read the configured timeout fromServerwithout reaching back into the auth config.WithCommandHostNameto extract an embedded port (e.g."host:9443") and apply it viaCommandPortso the SDK doesn't double-append a port to the URL.Authenticate()to reconstruct the URL with the non-default port when present.Context
The
ClientTimeoutgap was discovered while the terraform-provider-keyfactor consumed a local dev copy of kfc-auth — the go-client'sclient.goreferencescfg.ClientTimeoutwhich didn't exist onServer. This is the smallest fix to close that gap.Test plan